Maven Doxia
  1. Maven Doxia
  2. DOXIA-91

Update Doxia Decoration model to actually work in reactor build.

    Details

    • Number of attachments :
      6

      Description

      This is a major patch to the decoration model to bring some sanity in the link resolution when it is used under the reactor build. It generates breadcrumbs and item links correctly in all scenarios that I have tested (the current HEAD code does not) and passes all the unit tests that are already there.

      1. doxia-decoration.patch
        29 kB
        Henning Schmiedehausen
      2. doxia-decoration.patch
        16 kB
        Henning Schmiedehausen
      3. doxia-decoration-3.patch
        31 kB
        Henning Schmiedehausen
      4. doxia-decoration-4.patch
        51 kB
        Henning Schmiedehausen
      5. doxia-decoration-5.patch
        51 kB
        Henning Schmiedehausen
      6. org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest.txt
        26 kB
        Vincent Siveton

        Activity

        Hide
        Henning Schmiedehausen added a comment -

        Updated version for the doxia decoration patch. This should now avoid all possible NPE problems even with complex builds. Also adds some unit tests for the code.

        Show
        Henning Schmiedehausen added a comment - Updated version for the doxia decoration patch. This should now avoid all possible NPE problems even with complex builds. Also adds some unit tests for the code.
        Hide
        Henning Schmiedehausen added a comment -

        This patch also adds a number of unit tests. Unfortunately as I can not modify the issue, I can not change the "contains unit tests" field.

        Show
        Henning Schmiedehausen added a comment - This patch also adds a number of unit tests. Unfortunately as I can not modify the issue, I can not change the "contains unit tests" field.
        Hide
        Henning Schmiedehausen added a comment -

        the unit tests in the last patch actually depended on the existence of a "/tmp/foo" directory (they might report a trailing slash). This is an updated version where the unit tests pass in all cases. Still need to test on Windows, though.

        Show
        Henning Schmiedehausen added a comment - the unit tests in the last patch actually depended on the existence of a "/tmp/foo" directory (they might report a trailing slash). This is an updated version where the unit tests pass in all cases. Still need to test on Windows, though.
        Hide
        Jason van Zyl added a comment -

        Tests now pass and seem fine.

        Show
        Jason van Zyl added a comment - Tests now pass and seem fine.
        Hide
        Jason van Zyl added a comment -

        Patch applied.

        Show
        Jason van Zyl added a comment - Patch applied.

          People

          • Assignee:
            Jason van Zyl
            Reporter:
            Henning Schmiedehausen
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: