Maven Doxia

Add CSS style class to XHTML tags

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Won't Fix
  • Affects Version/s: 1.0-alpha-8
  • Fix Version/s: None
  • Component/s: Core
  • Labels:
    None
  • Number of attachments :
    2

Description

Add support for CSS style formatting with a class property on tags.

Previously filed http://jira.codehaus.org/browse/MNG-545.

Patches for core and sink-api for doxia-1.0-alpha-8 attached.

It provides the following fixes:

1. class property on list and numbered list tag
2. class property on paragraph tag
3. class property on link tag
4. target property on link tag
5. class property on table cells
6. class property on table header cells
7. class property on anchors

Is this an acceptable request or have people achieved CSS style differently when generating XHTML using Doxia?

Thanks

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

Patch need to be more generic.

Maybe a text configuration of how each element was written out.

Show
Vincent Siveton added a comment - Patch need to be more generic. Maybe a text configuration of how each element was written out.
Hide
Permalink
David Roussel added a comment -

It could be made more generic by changeing this:

if ( StringUtils.isNotEmpty( styleClass ) )
{
    write( "<li class=\"" + styleClass + "\">" );
}
else
{
     write( "<li>" );
}

into this:

writeTag( "li", styleClass);

or even:

Map<String,String> attributes = ... ;
writeTag( "li", attributes);
Show
David Roussel added a comment - It could be made more generic by changeing this: if ( StringUtils.isNotEmpty( styleClass ) ) { write( "<li class=\" " + styleClass + " \ ">" ); } else { write( "<li>" ); } into this: writeTag( "li" , styleClass); or even: Map< String , String > attributes = ... ; writeTag( "li" , attributes);
Hide
Permalink
Lukas Theussl added a comment -

I don't think it's necessary to modify the sink-api for that. Since it's html specific, we could just put those methods into XhtmlSink (or SiteRendererSink) only? Or is there a usecase where these events can be consumed by another sink?

Show
Lukas Theussl added a comment - I don't think it's necessary to modify the sink-api for that. Since it's html specific, we could just put those methods into XhtmlSink (or SiteRendererSink) only? Or is there a usecase where these events can be consumed by another sink?
Hide
Permalink
Vincent Siveton added a comment -

Is it reasonable to use CSS in a document like pdf?

Show
Vincent Siveton added a comment - Is it reasonable to use CSS in a document like pdf?
Hide
Permalink
Lukas Theussl added a comment -

More general solution implemented at DOXIA-204.

Show
Lukas Theussl added a comment - More general solution implemented at DOXIA-204 .

People

  • Assignee:
    Lukas Theussl
    Reporter:
    Vance Karimi
Vote (3)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: