Maven Doxia
  1. Maven Doxia
  2. DOXIA-493

Images within table are not shown

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5
    • Component/s: Module - Confluence
    • Labels:
      None
    • Environment:
      Windows/Linux
    • Patch Submitted:
      Yes
    • Number of attachments :
      2

      Description

      While working on project documentation I encountered a (at least I think) bug which is related to including images in tables. The example below doesn’t result in an image shown in the table cell but instead shows the inclusion as text (Unable to render embedded object: File (images/symbol.png) not found.).

      ||Symbol||Description||
      |!images/symbol.png!|text|
      

      After investigation I found out that the renderer of the table (TableBlockParser) only applies the ParagraphBlockParser and not other parsers like SectionBlockParser, FigureBlockParser, and ListBlockParser.

      To fix this I created the included patch. With this patch applied to version 1.4 of Doxia the example as shown above was properly parsed.

        Activity

        Hide
        Robert Scholte added a comment -

        Hi, thanks for the patch, really worth checking. Could you do me a small favour: Use the trunk instead of the tag (i.e. http://svn.apache.org/repos/asf/maven/doxia/doxia/trunk/doxia-modules/doxia-module-confluence/ ) and preserve the formatting ( see http://maven.apache.org/developers/conventions/code.html ).
        In the end we need a unittest as well to confirm the fix and to prevent regression. That's a bit tricky, so if needed I can help with that.

        Show
        Robert Scholte added a comment - Hi, thanks for the patch, really worth checking. Could you do me a small favour: Use the trunk instead of the tag (i.e. http://svn.apache.org/repos/asf/maven/doxia/doxia/trunk/doxia-modules/doxia-module-confluence/ ) and preserve the formatting ( see http://maven.apache.org/developers/conventions/code.html ). In the end we need a unittest as well to confirm the fix and to prevent regression. That's a bit tricky, so if needed I can help with that.
        Hide
        Mark Schenk added a comment -

        Added patch for trunk including unit test

        Show
        Mark Schenk added a comment - Added patch for trunk including unit test
        Hide
        Robert Scholte added a comment -

        Fixed in r1509970
        Thanks for the complete patch!

        Show
        Robert Scholte added a comment - Fixed in r1509970 Thanks for the complete patch!

          People

          • Assignee:
            Robert Scholte
            Reporter:
            Mark Schenk
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: