Maven Doxia
  1. Maven Doxia
  2. DOXIA-451

Tweak Doxia Markdown module HTML to better match

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: Module - Markdown
    • Labels:
      None
    • Testcase included:
      yes
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      The Doxia Markdown module currently uses the Pegdown module to generate HTML and then relies on the Doxia xhtml module to parse that. The Pegdown HTML generation currently produces HTML that doesn't exactly match what other modules produce, which causes some style errors. Specifically, for "code" blocks, there is no wrapping <div class="source"/> wrapper, which causes output to look strange. The attached patch adjusts the output.

      Of course, if the markdown module is going to be refactored to produce actual Doxia AST events, that might make this less of an issue. But I still think it'd be good to commit this patch in the meantime, especially if 1.3 is released before the refactoring.

        Activity

        Hide
        Lukas Theussl added a comment -

        Patch applied in r1185539. Thanks!

        Show
        Lukas Theussl added a comment - Patch applied in r1185539 . Thanks!

          People

          • Assignee:
            Lukas Theussl
            Reporter:
            Brian Ferris
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: