Maven Doxia

Xdoc: tables without "align" attribute is center aligned

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1.2
  • Fix Version/s: 1.1.3
  • Component/s: Core
  • Labels:
    None
  • Number of attachments :
    0

Description

If the Xdoc table doesn't have the align-attribute set, the produced xhtml gets this attribute: align="center". This is a regression compared to previous behavior.

I think that if no align-attribute is set in the Xdoc source file, then no align-attribute should be output in the xhtml document.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. DOXIA-221 Fix ArrayIndexOutOfBoundsException in XhtmlBaseSink

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. DOXIA-374 Xdoc: tables without "border" attribute get a border

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lukas Theussl added a comment -

Why is this a regression? I think specifying the alignment explicitly was necessary to guarantee the equivalent rendering to different sinks. Eg fo (used by the pdf plugin) specifies different default values for the align properties, so tables would look different in html and pdf even if produced from the same source document.

Show
Lukas Theussl added a comment - Why is this a regression? I think specifying the alignment explicitly was necessary to guarantee the equivalent rendering to different sinks. Eg fo (used by the pdf plugin) specifies different default values for the align properties, so tables would look different in html and pdf even if produced from the same source document.
Hide
Permalink
Dennis Lundberg added a comment -

It's a regression because it renders documents differently than previous versions did. I understand that specifying alignment might be necessary when producing documents multiple formats. But we should use previous behavior as default values whenever possible. Changing the default behavior will stand in the way of people trying to upgrade.

Show
Dennis Lundberg added a comment - It's a regression because it renders documents differently than previous versions did. I understand that specifying alignment might be necessary when producing documents multiple formats. But we should use previous behavior as default values whenever possible. Changing the default behavior will stand in the way of people trying to upgrade.
Hide
Permalink
Lukas Theussl added a comment - - edited

Fixed in r926049. The align attribute was inserted by the XhtmlBaseSink, which is certainly wrong. I also removed a corresponding align attribute that was inserted for table cells.

Show
Lukas Theussl added a comment - - edited Fixed in r926049 . The align attribute was inserted by the XhtmlBaseSink, which is certainly wrong. I also removed a corresponding align attribute that was inserted for table cells.

People

  • Assignee:
    Lukas Theussl
    Reporter:
    Dennis Lundberg
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: