[#DOXIA-316] Backward issue: wrong section counting in TOC macro - jira.codehaus.org

Maven Doxia

Backward issue: wrong section counting in TOC macro

Created: 07/May/09 05:14 AM Updated: 11/May/09 06:56 AM Resolved: 11/May/09 06:56 AM

Return to search

Component/s:

Core

Affects Version/s:

1.0

Fix Version/s:

1.1.1

Time Tracking:

Not Specified

Issue Links:

Related

This issue is related to:

DOXIA-317 wrong section counting in TOC macro

Description

« Hide

It seems that the definition of "depth" has changed in the TOC macro. For the following apt source:

%{toc|section=1|fromDepth=1|toDepth=1}

Section
* Sub-section 1
* Sub-section 2

Doxia 1.0 puts the list of sub-sections into the toc, Doxia 1.1 only the section.

Sort Order:

[ Permalink | « Hide ]

Lukas Theussl added a comment - 07/May/09 05:48 AM

Fixed in r772599.

Lukas Theussl made changes - 07/May/09 05:48 AM

Field	Original Value	New Value
Assignee		Lukas Theussl [ lukas ]
Resolution		Fixed [ 1 ]
Fix Version/s		1.1.1 [ 15073 ]
Status	Open [ 1 ]	Closed [ 6 ]

[ Permalink | « Hide ]

Lukas Theussl added a comment - 08/May/09 03:26 AM

Re-opening as this should really be counted as a bug in Doxia 1.0 and not a regression IMO. The problem is actually with the section counting, not the depth. Eg site-plugin-2.0 generates two different tocs for the following:

%{toc|section=1|fromDepth=1|toDepth=1}
%{toc|section=2|fromDepth=1|toDepth=1}

Section 1

* Sub-section 1.1
* Sub-section 1.2

Section 2

* Sub-section 2.1
* Sub-section 2.2

The toc for section 1 contains the two sub-sections, while the one for section 2 contains only the section.

Now I think that the current behavior of doxia 1.1 is correct, and consistent with the docs, but the problem is backward compatibility. All pages that contain a toc for a first section will be broken. So the question is: to fix or not to fix?

Lukas Theussl made changes - 08/May/09 03:26 AM

Status	Closed [ 6 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Lukas Theussl made changes - 08/May/09 03:27 AM

Affects Version/s	1.1 [ 13617 ]
Affects Version/s		1.0 [ 14834 ]
Summary	Backward issue: depth counting has changed in TOC macro	Backward issue: wrong section counting in TOC macro

Lukas Theussl made changes - 11/May/09 06:52 AM

Link

This issue is related to DOXIA-317 [ DOXIA-317 ]

[ Permalink | « Hide ]

Lukas Theussl added a comment - 11/May/09 06:56 AM

Fixed. Depth=1 is section, depth=2 is sub-section, etc, as documented.

Lukas Theussl made changes - 11/May/09 06:56 AM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Closed [ 6 ]