Using the last version of modello-maven-plugin

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0, 1.1
  • Fix Version/s: 1.0, 1.1
  • Component/s: Decoration Model
  • Labels:
    None

Description

modello-maven-plugin:1.0-alpha-21 produces errors in doxia-decoration-model project

  1. File
    DOXIA-254
    27/Sep/08 7:04 AM
    2 kB
    Olivier Lamy
  2. File
    testInheritence.diff
    22/Jan/09 6:40 AM
    2 kB
    Vincent Siveton

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MODELLO-83 Improvements for the generated methods equals(...), hashCode(), toString()

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Olivier Lamy added a comment -

fixing the xsd generation with attached patch generate junit issues.

Failed tests:
  testInheritence(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testFullyPopulatedParentAndEmptyChild(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testResolvingAllRelativeUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testResolvingAllSiteUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testLogoWithoutImage(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)

Tests run: 49, Failures: 5, Errors: 0, Skipped: 0
Show
Olivier Lamy added a comment - fixing the xsd generation with attached patch generate junit issues. 
Failed tests:
  testInheritence(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testFullyPopulatedParentAndEmptyChild(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testResolvingAllRelativeUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testResolvingAllSiteUrls(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)
  testLogoWithoutImage(org.apache.maven.doxia.site.decoration.inheritance.DecorationModelInheritenceAssemblerTest)

Tests run: 49, Failures: 5, Errors: 0, Skipped: 0
Hide
Permalink
Olivier Lamy added a comment -

patch which fix xsd generation

Show
Olivier Lamy added a comment - patch which fix xsd generation
Hide
Permalink
Vincent Siveton added a comment -

You did exactly what I did

Show
Vincent Siveton added a comment - You did exactly what I did
Hide
Permalink
Olivier Lamy added a comment -

What has changed in modello ? (I will try a diff on generated classes)
it looks to be a very WEIRD issue

Show
Olivier Lamy added a comment - What has changed in modello ? (I will try a diff on generated classes) it looks to be a very WEIRD issue
Hide
Permalink
Vincent Siveton added a comment -

The change is in MenuItem#equals(Object other) which uses also super.equals(), introduced by MODELLO-83.

Show
Vincent Siveton added a comment - The change is in MenuItem#equals(Object other) which uses also super.equals(), introduced by MODELLO-83.
Hide
Permalink
Vincent Siveton added a comment -

The tests like testInheritence() were originally wrong.

I tried to debug the mergedModel and childModel object using Xstream. The attachment shows the Xstream differences: mainly links in childModel should be .. (dotdot) I will fix tests under latest Modello.

Show
Vincent Siveton added a comment - The tests like testInheritence() were originally wrong. I tried to debug the mergedModel and childModel object using Xstream. The attachment shows the Xstream differences: mainly links in childModel should be .. (dotdot) I will fix tests under latest Modello.
Hide
Permalink
Vincent Siveton added a comment -

fixed in r736628

Show
Vincent Siveton added a comment - fixed in r736628
Hide
Permalink
Dennis Lundberg added a comment -

Thanks for looking into this Vincent.

I have been trying to fix this on the 1.0.x branch before I release 1.0.

Do you think it's possible/preferable to merge r736628 to the 1.0.x branch?

Show
Dennis Lundberg added a comment - Thanks for looking into this Vincent. I have been trying to fix this on the 1.0.x branch before I release 1.0. Do you think it's possible/preferable to merge r736628 to the 1.0.x branch?
Hide
Permalink
Vincent Siveton added a comment -

Dennis, I was thinking to ping you since you are our official branch maintainer! So feel free to do it

Show
Vincent Siveton added a comment - Dennis, I was thinking to ping you since you are our official branch maintainer! So feel free to do it
Hide
Permalink
Vincent Siveton added a comment -

An other comment, FYI the generated XSD is actually wrong, but it is fixed with the modello beta-1

Show
Vincent Siveton added a comment - An other comment, FYI the generated XSD is actually wrong, but it is fixed with the modello beta-1
Hide
Permalink
Dennis Lundberg added a comment -

This issue is now fixed for the 1.0 branch as well.

Show
Dennis Lundberg added a comment - This issue is now fixed for the 1.0 branch as well.

People

  • Assignee:
    Vincent Siveton
    Reporter:
    Vincent Siveton
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: