Add support for level 6 sections and generalize Sink API for sections

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.0-alpha-10
  • Fix Version/s: None
  • Component/s: Sink API
  • Labels:
    None

Description

XWiki supports 6 levels (see http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax) and thus I cannot write a valid parser if the Sink API doesn't support a level 6.

I'd even suggest to unify all sink method for sections into a single method with a level parameter passed instead of having sectionTitle1(), etc.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

I already thought about this and I am generally in favour on this general approach, but we dont want to remove these methods, more now on beta.

Show
Vincent Siveton added a comment - I already thought about this and I am generally in favour on this general approach, but we dont want to remove these methods, more now on beta.
Hide
Permalink
Vincent Massol added a comment -

well if we say that 1.0 is not released yet then we should remove the old cruft and not deprecate them.

If OTOH we think that 1.0 has already been released in practice (if not de facto) then let's create a 1.0 branch, and make trunk be 1.1 or 2.0 and remove the cruft there.

WDYT?

Show
Vincent Massol added a comment - well if we say that 1.0 is not released yet then we should remove the old cruft and not deprecate them. If OTOH we think that 1.0 has already been released in practice (if not de facto) then let's create a 1.0 branch, and make trunk be 1.1 or 2.0 and remove the cruft there. WDYT?
Hide
Permalink
Lukas Theussl added a comment -

There is an issue (don't know if it's an inconsistency) with the xhtml-based parsers and sinks: eg sectionTitle1() in XhtmlBaseSink emits a <h2> tag, sectionTitle2() a <h3> etc, sectionTitle5() emits a <h6> but there is no method that emits a <h1>.

Show
Lukas Theussl added a comment - There is an issue (don't know if it's an inconsistency) with the xhtml-based parsers and sinks: eg sectionTitle1() in XhtmlBaseSink emits a <h2> tag, sectionTitle2() a <h3> etc, sectionTitle5() emits a <h6> but there is no method that emits a <h1>.

People

  • Assignee:
    Unassigned
    Reporter:
    Vincent Massol
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: