Maven Doxia

Confluence support for img macro

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-9
  • Fix Version/s: 1.1
  • Component/s: Module - Confluence
  • Labels:
    None
  • Number of attachments :
    2

Description

Confluence support for img macro

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dave Syer added a comment -

Attached patch (figure-patch). It doesn't use the img macro because the ! shortcut is more often used and supported on confluence wikis.

There is an issue with Doxia figure captions (also in Apt) which is that people want to a) see the caption in rendered HTML, b) be able to add formatting to it. You can't do either with Apt, so I presereved that behaviour here because other sinks (PDF, Docbook etc) should do something more sensible with figure captions.

Show
Dave Syer added a comment - Attached patch (figure-patch). It doesn't use the img macro because the ! shortcut is more often used and supported on confluence wikis. There is an issue with Doxia figure captions (also in Apt) which is that people want to a) see the caption in rendered HTML, b) be able to add formatting to it. You can't do either with Apt, so I presereved that behaviour here because other sinks (PDF, Docbook etc) should do something more sensible with figure captions.
Hide
Permalink
Lukas Theussl added a comment -

Patch applied, thanks!

Just two minor remarks: your patch changed quite a lot of layout/formatting, in particular inside comments, please try to limit the content of patches to only the necessary stuff. Second: new java source files need to have the apache license on top.

Show
Lukas Theussl added a comment - Patch applied, thanks! Just two minor remarks: your patch changed quite a lot of layout/formatting, in particular inside comments, please try to limit the content of patches to only the necessary stuff. Second: new java source files need to have the apache license on top.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.