Maven Doxia

Confluence parser doesn't strip leading space for section titles

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-9
  • Fix Version/s: 1.1
  • Component/s: Module - Confluence
  • Labels:
    None
  • Number of attachments :
    4

Description

For example for "h1. Hello", it'll send " Hello" to the text() Sink API instead of "Hello".

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dave Syer added a comment -

N.B. this patch also includes the patch for DOXIA-169 (the updated version "-1").

Show
Dave Syer added a comment - N.B. this patch also includes the patch for DOXIA-169 (the updated version "-1").
Hide
Permalink
Lukas Theussl added a comment -

Dave, this patch gives me a build error, I think you forgot to include the LinebreakBlock class from DOXIA-169. Anyway, I have applied the patch there, could you attach a separate patch for only this issue here? Thanks.

Show
Lukas Theussl added a comment - Dave, this patch gives me a build error, I think you forgot to include the LinebreakBlock class from DOXIA-169. Anyway, I have applied the patch there, could you attach a separate patch for only this issue here? Thanks.
Hide
Permalink
Dave Syer added a comment -

I could't provide a separate patch until you applied the other one. It's not very efficient, but I guess it's the only way? New patch is *-1

Show
Dave Syer added a comment - I could't provide a separate patch until you applied the other one. It's not very efficient, but I guess it's the only way? New patch is *-1
Hide
Permalink
Lukas Theussl added a comment -

Applied, thanks!

I think it's generally a good idea to only attach patches for the issue under consideration. It's not a big deal for simple fixes like this one, but otherwise it's hard to keep things apart when reviewing the patch, especially if the code has evolved in the meantime.

Show
Lukas Theussl added a comment - Applied, thanks! I think it's generally a good idea to only attach patches for the issue under consideration. It's not a big deal for simple fixes like this one, but otherwise it's hard to keep things apart when reviewing the patch, especially if the code has evolved in the meantime.
Hide
Permalink
Dave Syer added a comment -

Agreed, but it's also impossible to create a patch for one issue if the changes from another issue have not been comitted yet - unless you know something I don't.

Show
Dave Syer added a comment - Agreed, but it's also impossible to create a patch for one issue if the changes from another issue have not been comitted yet - unless you know something I don't.
Hide
Permalink
Vincent Massol added a comment -

You can use:

1) the shelve changes feature of IDEA 7
2) a tool that handles patches like Quilt (http://www.coffeebreaks.org/blogs/wp-content/archives/talks/2005/quilt/quiltintro-s5.html)
3) wait for the patch to be applied

My preference goes to 1) but that's because I'm an IDEA user.

Show
Vincent Massol added a comment - You can use: 1) the shelve changes feature of IDEA 7 2) a tool that handles patches like Quilt (http://www.coffeebreaks.org/blogs/wp-content/archives/talks/2005/quilt/quiltintro-s5.html) 3) wait for the patch to be applied My preference goes to 1) but that's because I'm an IDEA user.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.