Confluence module does not recognize line breaks (\\)

Dave, is this a duplicate of DOXIA-162?

No, not really. This is about the confluence markup for an explicit line ending - two backslashes (which I don't know how to write verbatim here). DOXIA-162 is definitely more urgent than this one, even though it is quite irritating.

Patch relative to modules directory.

I've had a quick look at this patch and have some issues:

• first, please adhere to our coding conventions, in particular, no tabs, no System.out/err
• the EOL string is available to the ConfluenceParser through the Markup interface, it should also be available to the BlockParser
• a confluence linebreak element should produce a sink lineBreak(), not an EOL. Ie, your test input

Line\\
break.

should produce the following TextSink output:

begin:paragraph
text: Line
lineBreak
text: break.
end:paragraph

instead of

begin:paragraph
text: Line
break.
end:paragraph

• last but not least: in the future I will refuse to apply any patch that has the doxia tree checked out under a directory called 'crap'...

• Coding conventions: is there an Eclipse prefs file anywhere?
• EOL - wasn't needed in the parser but thanks for the tip.
• lineBreak - didn't know about that one, thank.
• "crap" is just a name. In the future I will refuse to submit patches if arbitrary rules are applied to them.

Maybe I'm not the right person to be doing this. If there are rules and pieces of Doxia knowledge that other people know more about I am quite happy to sit back and wait. But obviously I won't be using the Confluence module until it is in better shape.

Coding conventions: http://maven.apache.org/guides/development/guide-m2-development.html#Maven_Code_Style

For the crap line: it was meant as a pun, don't let my bad english prevent you from calling your patches whatever you want...

If you are not the right person for doing this, then I don't see who else, because as you might have inferred from the response on the list, none of the current doxia committers is that familiar with the confluence module. So please, keep the patches coming, I promise we'll have at least a look at it.

Updated patch (*-1.txt) with correct use of lineBreak().

Patch applied, thanks!

Note that I have put the LineBreak test into ConfluenceParserTest, if you extend it then the base tests get executed twice.

I get a compile error when I update from SVN after the patch weas applied - EOL is not resolved. Did you mean to expose it in the base class?