Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.0-alpha-8
-
Fix Version/s: 1.1
-
Component/s: Module - Confluence
-
Labels:None
-
Number of attachments :
Description
Confluence module does not recognize line breaks (
)
Attachments
Activity
Hide
Lukas Theussl
added a comment -
I've had a quick look at this patch and have some issues:
- first, please adhere to our coding conventions, in particular, no tabs, no System.out/err
- the EOL string is available to the ConfluenceParser through the Markup interface, it should also be available to the BlockParser
- a confluence linebreak element should produce a sink lineBreak(), not an EOL. Ie, your test input
Line\\ break.
should produce the following TextSink output:
begin:paragraph text: Line lineBreak text: break. end:paragraph
instead of
begin:paragraph text: Line break. end:paragraph
- last but not least: in the future I will refuse to apply any patch that has the doxia tree checked out under a directory called 'crap'...
Show
Lukas Theussl
added a comment - I've had a quick look at this patch and have some issues:
should produce the following TextSink output:
instead of
- first, please adhere to our coding conventions, in particular, no tabs, no System.out/err
- the EOL string is available to the ConfluenceParser through the Markup interface, it should also be available to the BlockParser
- a confluence linebreak element should produce a sink lineBreak(), not an EOL. Ie, your test input
Line\\ break.
begin:paragraph text: Line lineBreak text: break. end:paragraph
begin:paragraph text: Line break. end:paragraph
- last but not least: in the future I will refuse to apply any patch that has the doxia tree checked out under a directory called 'crap'...
Hide
Lukas Theussl
added a comment -
Coding conventions: http://maven.apache.org/guides/development/guide-m2-development.html#Maven_Code_Style
For the crap line: it was meant as a pun, don't let my bad english prevent you from calling your patches whatever you want... 
If you are not the right person for doing this, then I don't see who else, because as you might have inferred from the response on the list, none of the current doxia committers is that familiar with the confluence module. So please, keep the patches coming, I promise we'll have at least a look at it.
Show
Lukas Theussl
added a comment - Coding conventions: http://maven.apache.org/guides/development/guide-m2-development.html#Maven_Code_Style
For the crap line: it was meant as a pun, don't let my bad english prevent you from calling your patches whatever you want...
If you are not the right person for doing this, then I don't see who else, because as you might have inferred from the response on the list, none of the current doxia committers is that familiar with the confluence module. So please, keep the patches coming, I promise we'll have at least a look at it.
If you are not the right person for doing this, then I don't see who else, because as you might have inferred from the response on the list, none of the current doxia committers is that familiar with the confluence module. So please, keep the patches coming, I promise we'll have at least a look at it.
Dave, is this a duplicate of
DOXIA-162?DOXIA-162?