Maven Doxia

Apt parser issues

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-alpha-8
  • Fix Version/s: 1.1.1
  • Component/s: Module - Apt
  • Labels:
    None
  • Number of attachments :
    3

Description

I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:

  1. the parser swallows newlines between text elements
  2. a paragraph within a list item is swallowed
  3. verbatim text within a definition list item is not processed correctly
  4. the closing of a definition list is not processed correctly
  5. table header cells are not recognized and newlines within table cells are not processed correctly

Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).

Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.

Attachments

  1. Text File
    actual.txt
    14/Jul/07 4:25 AM
    5 kB
    Lukas Theussl
  2. Text File
    DOXIA-134-headerCell.patch
    23/Jul/07 8:40 AM
    0.7 kB
    Denis Cabasson
  3. Text File
    expected.txt
    14/Jul/07 4:25 AM
    5 kB
    Lukas Theussl

Issue Links

This issue relates to:
DOXIA-38 Independent row parsing Minor Closed
This issue supercedes:
DOXIA-149 Don't break lines in apt generated table cells Trivial Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Denis Cabasson added a comment -

submitted patch should correct (at least to some extend) point 5, handling headerCells in AptSink.

Point 1 looks sensible to me (stripping non significant EOL).

Could you attach a full test case so I can try to re-play it?

Show
Denis Cabasson added a comment - submitted patch should correct (at least to some extend) point 5, handling headerCells in AptSink. Point 1 looks sensible to me (stripping non significant EOL). Could you attach a full test case so I can try to re-play it?
Hide
Permalink
Lukas Theussl added a comment -

Patch applied, thanks!
I need to do some house cleaning but I will soon attach a more complete patch to DOXIA-101, that will allow you to re-produce my results.

Show
Lukas Theussl added a comment - Patch applied, thanks! I need to do some house cleaning but I will soon attach a more complete patch to DOXIA-101, that will allow you to re-produce my results.
Hide
Permalink
Lukas Theussl added a comment -

The classes I used to generate those files are in SVN now, just run 'mvn test' in the apt module.

Show
Lukas Theussl added a comment - The classes I used to generate those files are in SVN now, just run 'mvn test' in the apt module.
Hide
Permalink
Lukas Theussl added a comment -

r596011 fixed points 2. and 4. The only two issues remaining are lineBreaks in table cells and verbatim blocks.

Show
Lukas Theussl added a comment - r596011 fixed points 2. and 4. The only two issues remaining are lineBreaks in table cells and verbatim blocks.
Hide
Permalink
Lukas Theussl added a comment -

Verbatim blocks are fixed in r661590, only the issue with lineBreaks in table cells remains...

Show
Lukas Theussl added a comment - Verbatim blocks are fixed in r661590, only the issue with lineBreaks in table cells remains...
Hide
Permalink
Vincent Siveton added a comment -

I fixed the issues about multiline and linebreak in table cells in r773851

Show
Vincent Siveton added a comment - I fixed the issues about multiline and linebreak in table cells in r773851

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.