Issue Details (XML | Word | Printable)

Key: DOXIA-134
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Vincent Siveton
Reporter: Lukas Theussl
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Maven Doxia

Apt parser issues

Created: 14/Jul/07 04:25 AM   Updated: 12/May/09 06:08 AM   Resolved: 12/May/09 06:07 AM
Return to search
Component/s: Module - Apt
Affects Version/s: 1.0-alpha-8
Fix Version/s: 1.1.1

Time Tracking:
Not Specified

File Attachments: 1. Text File actual.txt (5 kB)
2. Text File DOXIA-134-headerCell.patch (0.7 kB)
3. Text File expected.txt (5 kB)

Issue Links:
Related
 
Supercedes
 


 Description  « Hide

I did the following experiment: using the SinkTestDocument that I attached at DOXIA-101 I generated two text documents, one by dumping the model directly into a text sink, the other by piping it through the current apt sink, parsing the result with the apt parser and dumping it into the same text sink as before. The results should be the same since the second chain corresponds to the 'identity transformation', ie piping a document through a parser and sink should give you the original document. I attach the two text files for comparison, here are the differences:

  1. the parser swallows newlines between text elements
  2. a paragraph within a list item is swallowed
  3. verbatim text within a definition list item is not processed correctly
  4. the closing of a definition list is not processed correctly
  5. table header cells are not recognized and newlines within table cells are not processed correctly

Point 1 is not severe by itself because newlines are not significant in apt source documents, however, two newlines are, so I am not sure if it doesn't have consequences (eg within table cells).

Point 5 has partially been fixed by the patch Vincent attached at DOXIA-50.



Denis Cabasson added a comment - 23/Jul/07 08:40 AM

submitted patch should correct (at least to some extend) point 5, handling headerCells in AptSink.

Point 1 looks sensible to me (stripping non significant EOL).

Could you attach a full test case so I can try to re-play it?


Lukas Theussl added a comment - 23/Jul/07 01:20 PM

Patch applied, thanks!
I need to do some house cleaning but I will soon attach a more complete patch to DOXIA-101, that will allow you to re-produce my results.


Lukas Theussl added a comment - 25/Jul/07 04:59 PM

The classes I used to generate those files are in SVN now, just run 'mvn test' in the apt module.


Lukas Theussl added a comment - 17/Nov/07 04:11 PM

r596011 fixed points 2. and 4. The only two issues remaining are lineBreaks in table cells and verbatim blocks.


Lukas Theussl added a comment - 30/May/08 03:42 AM

Verbatim blocks are fixed in r661590, only the issue with lineBreaks in table cells remains...


Vincent Siveton added a comment - 12/May/09 06:07 AM

I fixed the issues about multiline and linebreak in table cells in r773851