Maven Doxia

When using a template from a custom skin, default images and css from doxia-site-renderer are not copied to rendered site

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.0-alpha-8
  • Fix Version/s: None
  • Component/s: Site Renderer
  • Labels:
    None
  • Environment:
    maven-site-plugin 2.0-beta-5; maven 2.0.5
  • Number of attachments :
    0

Description

I've created my own Velocity template for rendering site pages, and included it in my own site skin. The skin makes no changes to the built-by image, or the maven-base or print CSS files. However, when I use the new skin, none of these files are found in the site. This leads to massive formatting problems and missing icons/images all over the place.

When I copy the images/ and css/ directories out of the doxia-site-renderer/src/main/resources/... directory structure into my skin, all is fine.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dennis Lundberg added a comment -

This is the behavior that I would expect. Anyone who creates a skin should supply the needed images and style sheets for it.

Were you expecting the images and style sheets to be "inherited" from a parent skin, or site renderer itself?

Show
Dennis Lundberg added a comment - This is the behavior that I would expect. Anyone who creates a skin should supply the needed images and style sheets for it. Were you expecting the images and style sheets to be "inherited" from a parent skin, or site renderer itself?
Hide
Permalink
Grégory Joseph added a comment - - edited

Based on the names of the css files, I'd actually expect maven-base.css to always be copied (possibly overriden if the skin author should chose so), whereas maven-theme.css would be where the actual theming happens. Having maven-base.css there would help when new versions of the site components are released, providing good defaults until the skin author wants to further customize them. (and generally avoiding unnecessary copy pasting of these files)

Show
Grégory Joseph added a comment - - edited Based on the names of the css files, I'd actually expect maven-base.css to always be copied (possibly overriden if the skin author should chose so), whereas maven-theme.css would be where the actual theming happens. Having maven-base.css there would help when new versions of the site components are released, providing good defaults until the skin author wants to further customize them. (and generally avoiding unnecessary copy pasting of these files)
Hide
Permalink
Grégory Joseph added a comment - - edited

I'd expect the same for all resources, not just the css - currently skins have to copy all resources, icons etc. Having overridable defaults would be nice.

Show
Grégory Joseph added a comment - - edited I'd expect the same for all resources, not just the css - currently skins have to copy all resources, icons etc. Having overridable defaults would be nice.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.