Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 1.2
-
Component/s: Decorators
-
Labels:None
Description
In Column class we have such code:
// if a decorator has been set, and if decorator has a getter for the requested property only, check
// decorator
if (decorated
&& this.row.getParentTable().getTableDecorator() != null
&& this.row.getParentTable().getTableDecorator().hasGetterFor(this.header.getBeanPropertyName()))
which checks if table decorator has getter for property of the data row (I have no idea why it should).
If decorator has no getter, the flow goes to Decorator.searchGetterFor() which checks the getter using code:
PropertyDescriptor pd = PropertyUtils.getPropertyDescriptor(this, propertyName);
PropertyUtils throws then NoSuchMethodException and Decorator puts the stacktrace into log, suggesting something is wrong in application.
Shouldn't it only return null?
// if a decorator has been set, and if decorator has a getter for the requested property only, check
// decorator
if (decorated
&& this.row.getParentTable().getTableDecorator() != null
&& this.row.getParentTable().getTableDecorator().hasGetterFor(this.header.getBeanPropertyName()))
which checks if table decorator has getter for property of the data row (I have no idea why it should).
If decorator has no getter, the flow goes to Decorator.searchGetterFor() which checks the getter using code:
PropertyDescriptor pd = PropertyUtils.getPropertyDescriptor(this, propertyName);
PropertyUtils throws then NoSuchMethodException and Decorator puts the stacktrace into log, suggesting something is wrong in application.
Shouldn't it only return null?