[#DISPL-370] display tag row number object not cleaing up when any exceptions happen, this forcing server restart - jira.codehaus.org

DisplayTag

display tag row number object not cleaing up when any exceptions happen, this forcing server restart

Created: 29/Jun/06 07:21 AM Updated: 20/Dec/07 08:19 AM

Return to search

Component/s:

Paging/Sorting

Affects Version/s:

1.1

Fix Version/s:

None

Time Tracking:

Original Estimate:

4 hours

Remaining Estimate:

4 hours

Time Spent:

Not Specified

Application server:

Oracle 10g application server release 2

Description

« Hide

if any exception happens the row number used by TableTag class is getting increased, and not getting reset. server output as follows, if you see the server output only release mehtod is called and not the cleanup method. after exception, refreshing the page keep on increasing the row number count and ending up with exception. only restarting the server cleaning up the objects and it is working fine there after.

Suggestion:

TableTag.release() method should call cleanUp as well.

Regards,
Senthil Mohan

DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928)
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928)
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928)
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doAfterBody called - iterating on row 5928
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doIteration called
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.model.TableModel) - [row] adding row Row[rowNumber=5928,rowObject=com.elink.Planning.PlanningData@b99561]
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doIteration() - iterator ended after 5928 rows
DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doEndTag called
DEBUG [2006-06-29 12:36:31,420] (org.apache.commons.beanutils.BeanUtils) - Describing bean: com.elink.Planning.PlanningData
DEBUG [2006-06-29 12:36:31,421] (org.displaytag.model.TableModel) - [row] sorting full data
DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@4d9e2e
DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@4d9e2e
DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@1cc093f
DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@1cc093f
DEBUG [2006-06-29 12:36:31,441] (org.displaytag.tags.TableTag) - [row] release() called

Description

if any exception happens the row number used by TableTag class is getting increased, and not getting reset. server output as follows, if you see the server output only release mehtod is called and not the cleanup method. after exception, refreshing the page keep on increasing the row number count and ending up with exception. only restarting the server cleaning up the objects and it is working fine there after. Suggestion: TableTag.release() method should call cleanUp as well. Regards, Senthil Mohan DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928) DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928) DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] first iteration=false (row number=5928) DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doAfterBody called - iterating on row 5928 DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doIteration called DEBUG [2006-06-29 12:36:31,420] (org.displaytag.model.TableModel) - [row] adding row Row[rowNumber=5928,rowObject=com.elink.Planning.PlanningData@b99561] DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doIteration() - iterator ended after 5928 rows DEBUG [2006-06-29 12:36:31,420] (org.displaytag.tags.TableTag) - [row] doEndTag called DEBUG [2006-06-29 12:36:31,420] (org.apache.commons.beanutils.BeanUtils) - Describing bean: com.elink.Planning.PlanningData DEBUG [2006-06-29 12:36:31,421] (org.displaytag.model.TableModel) - [row] sorting full data DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@4d9e2e DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@4d9e2e DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@1cc093f DEBUG [2006-06-29 12:36:31,421] (org.displaytag.util.LookupUtil) - getProperty [noOfCollections] on bean com.elink.Planning.PlanningData@1cc093f DEBUG [2006-06-29 12:36:31,441] (org.displaytag.tags.TableTag) - [row] release() called

Show »

Sort Order:

[ Permalink | « Hide ]

Bernhard Mähr added a comment - 20/Dec/07 08:19 AM

Same problem here. If e.g. a getter for a rendered row-item throws an exception all pages with displaytag-tables gets unusable for all users until a serverrestart. The suggested fix works here and would also be my suggestion.

cleanUp(); should be removed from TableTag.java:1226 and added to TableTag.java:1628.

Bernhard Mähr at opitz-consulting dot de