|
Sort Order:
fabrizio giustina made changes - 09/Mar/06 03:34 PM
I am attaching a patch which I believe fixes this issue.
At the heart of the problem is SmartListHelper.getLastIndexForPage() and SmartListHelper.getFirstIndexForPage(). These calls should not be differentiating between partial and non-partial lists. To the best of my knowledge, they only made this difference for the benefit of SmarListHelper.getListForPage(). I moved the special case code out of SmartListHelper.getLastIndexForPage() and SmartListHelper.getFirstIndexForPage() and into SmarListHelper.getListForPage(). This appears to fix this issue. Kevin
Kevin Conaway made changes - 15/Mar/06 02:00 PM
just wanted to comment that I encountered the same issue.... almost a year after the issue was first reported.....
Is there anyone working to fix bugs on this project? Hi Dave,
If you're unable to apply the patch that I attached to this issue, I would be happy to mail you my patched jar file that we've been using for a year or so now. You can reach me: kevin dot a dot conaway at gmail dot com Kevin, thanks!! I just sent you an email.
Hi,
I'm also facing this issue but i'm unable to apply the patch attached to it. Can somebody please send me a jar file with this issue fixed? Thanks a lot, ps: i'm reachable at: wbcharpentier@avantias.com
fabrizio giustina made changes - 14/Aug/07 04:48 PM
Is anyone going to do anything about this one? hello? mc fly!
sorry to be a nag. I hope that patch works. after some hacking i was able to apply the patch, since it looks like this project is not very active, if anyone needs a copy click on my name & i can email it.
thanks for the patch! fix applied and testcase added, will be available in the 1.1.2 release. Thanks
fabrizio giustina made changes - 24/Aug/07 12:57 AM
we are facing this issue with displaytag 1.1.1 version. we are not able to apply this patch.
can you please send me patch applied jar file. It's urgent for me. Hey, I am also having the same issue with displaytag 1.1.1 version. Is it possible for someone to send me this patch in a jar.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bug
Closed
Major
External paging paging.banner.some_items_found displays 1-10 in the second page (other pages as well)
// return the min of pageSize or list size on the off chance they gave us more data than pageSize allows
return Math.min(this.pageSize - 1, this.fullList.size() - 1);
It seems that these functions are necessary because SmartListHelper.getListForPage() uses both of these methods to determine the "sublist" to display.
However, these numbers do NOT seem appropriate for the "search" banner returned by SmartListHelper.getSearchResultsSummary(). In this method, I think its best to compute the "indices" differently possibly using a combination of the current page and the page size.
Please advise. Thanks,
Kevin