HTML title not added with chopped value (column tag - maxLength attribute)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1
  • Component/s: HTML Generation
  • Labels:
    None

Description

The bug applies to the maxLength feature in the columntag:

In org.displaytag.model.Column.createChoppedAndLinkedValue() Strings which are longer than maxLength are chopped and '...' is appended to them.

But a html title is only added to the column, if <code>if (choppedValue.length() < fullValue.length())</code> :

The appended '...' are forgotten. This results in Strings beeing chopped and no html-title added if (stringlength > maxLength and stringlength <= maxLength+3)

a possible quickfix:

<code>if (choppedValue.length() - 3 < fullValue.length())</code>

Activity

Hide
Permalink
fabrizio giustina added a comment -
fixed in CVS for 1.1
note that the fix is different form the suggested, since checking length - "..." could also return true for a String which was not cropped.
Show
fabrizio giustina added a comment - fixed in CVS for 1.1 note that the fix is different form the suggested, since checking length - "..." could also return true for a String which was not cropped.

People

  • Reporter:
    Anonymous
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: