jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • DisplayTag
  • DISPL-231

Property files are read for every table generated

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1
  • Component/s: Build/distribution
  • Labels:
    None
  • Application server:
    WebSphere

Description


Every time a table is generated, the property files are accessed. In TableProperties.java getLocaleResolverInstance(), some code is executed without useing the result. By moving a if-clause to the top of the method, the code won't be executed, and we will get a performance gain. I have implemented the change in my locale version, at it works fine. I have also attached the new version of TableProperties.java (see line 409).

Following change has been done:
class: TableProperties.java
method: getLocaleResolverInstance()

Moved if(localeResolver == null){ from line 433 to line 409.

The localeResolver is null only first time a table is generated, the rest of the tables will use the localeResolver found first time.

  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Java Source File
    TableProperties.java
    09/Aug/05 12:28 PM
    38 kB
    Fredrik Dahl-Jørgensen

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
fabrizio giustina added a comment - 29/Oct/05 9:38 AM
fixed in cvs as suggested. Thanks
Show
fabrizio giustina added a comment - 29/Oct/05 9:38 AM fixed in cvs as suggested. Thanks

People

  • Reporter:
    Anonymous
Vote (3)
Watch (1)

Dates

  • Created:
    09/Aug/05 12:28 PM
    Updated:
    29/Oct/05 9:38 AM
    Resolved:
    29/Oct/05 9:38 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.