DisplayTag
  1. DisplayTag
  2. DISPL-230

Add position option for export links (export.banner.placement) - Similar to paging.banner.placement

    Details

    • Type: Improvement Improvement
    • Status: Resolved Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: 2.0
    • Component/s: Export
    • Labels:
      None

      Description

      Add the ability to set the export banner to either TOP, BOTTOM, BOTH (similar to paging banner placement).

      I've got the code working, I'll clean it and send it up.

        Activity

        Hide
        Peter Daugavietis added a comment -
        The 2 files updated are TableTag.java and TableProperties.java.

        the new property is : export.banner.placement=top|bottom|both
        Show
        Peter Daugavietis added a comment - The 2 files updated are TableTag.java and TableProperties.java. the new property is : export.banner.placement=top|bottom|both
        Hide
        Peter Daugavietis added a comment -
        I apologize if i've done something the wrong way or not -- first time contributing back something.

        Please let me know if/how to better do this in the future.
        Show
        Peter Daugavietis added a comment - I apologize if i've done something the wrong way or not -- first time contributing back something. Please let me know if/how to better do this in the future.
        Hide
        fabrizio giustina added a comment -
        Thanks for the contribution, I will try to integrate it after the 1.1 release.
        Btw, a the correct way to post patches is by attaching a diff (and not the full source code) + appropriate unit tests and documentation update. See http://displaytag.sourceforge.net/11/issue-tracking.html
        Show
        fabrizio giustina added a comment - Thanks for the contribution, I will try to integrate it after the 1.1 release. Btw, a the correct way to post patches is by attaching a diff (and not the full source code) + appropriate unit tests and documentation update. See http://displaytag.sourceforge.net/11/issue-tracking.html
        Hide
        Tahiry FENO added a comment -
        thanks for this patch, i had to modify:
        - TableProperties.java : getAddExportBannerTop() should use the new property PROPERTY_STRING_EXPORTBANNER_PLACEMENT
        - TableTag.java : writeHTMLData() should check if export is activated and if there is data to export before calling writeExportLinks() :
        if (this.export && this.properties.getAddExportBannerTop() && this.tableModel.getRowListPage().size() != 0) //...
        Show
        Tahiry FENO added a comment - thanks for this patch, i had to modify: - TableProperties.java : getAddExportBannerTop() should use the new property PROPERTY_STRING_EXPORTBANNER_PLACEMENT - TableTag.java : writeHTMLData() should check if export is activated and if there is data to export before calling writeExportLinks() : if (this.export && this.properties.getAddExportBannerTop() && this.tableModel.getRowListPage().size() != 0) //...
        Hide
        Mike Calmus added a comment -
        Any update on getting this included? Based upon discussion it looks like the patch should be largely ready.
        Show
        Mike Calmus added a comment - Any update on getting this included? Based upon discussion it looks like the patch should be largely ready.
        Hide
        Mike Calmus added a comment -
        Here is an updated patch done on the latest subversion code.
        Show
        Mike Calmus added a comment - Here is an updated patch done on the latest subversion code.
        Hide
        Mike Calmus added a comment -
        Fixed a typo in the original patch that used the wrong property label.
        Also using bottom as default value to ensure proper backward behavior.
        Show
        Mike Calmus added a comment - Fixed a typo in the original patch that used the wrong property label. Also using bottom as default value to ensure proper backward behavior.
        Hide
        Diptesh Chakraborty added a comment -
        How do I attach the above files into my existing projects..I have used displaytag1.2 jar in my application. How do I add TableTag and TableProperties class into my project?
        Show
        Diptesh Chakraborty added a comment - How do I attach the above files into my existing projects..I have used displaytag1.2 jar in my application. How do I add TableTag and TableProperties class into my project?
        Hide
        fabrizio giustina added a comment -
        added in 2.0
        Show
        fabrizio giustina added a comment - added in 2.0

          People

          • Reporter:
            Anonymous
          • Votes:
            4 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 6 hours
              6h
              Remaining:
              Remaining Estimate - 6 hours
              6h
              Logged:
              Time Spent - Not Specified
              Not Specified