jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Continuum
  • CONTINUUM-838

Cross Site Request Forgery protection

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.0, 1.0.1, 1.0.2, 1.0.3, 1.1-alpha-1
  • Fix Version/s: Backlog
  • Component/s: Web interface
  • Labels:
    None
  • Complexity:
    Intermediate

Description

XSRF vulnerabilities are very hard to fix. More details on them at http://en.wikipedia.org/wiki/Cross-site_request_forgery with a key document found at http://isecpartners.com/documents/XSRF_Paper.pdf which outlines a solution.

In short, an XSRFProtectionToken is passed in each form in a hidden variable, with the XSRFProtectionToken consisting of (pseudocode):

hash(sessionid + actionName + sitewide_secret);

The hash can be MD5 or SHA-1 or whatever. The important thing is that even if a user is logged on with a valid sessionId, the attacker cannot know in advance what the token will be without getting it out of an insecure browser (in which case, you have other problems). Even if the attacker gets access to a token for one action that's less security-risky (like invoking a build), they cannot then replay that token against something more risky (such as creating a new admin user).

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Brett Porter added a comment - 21/Apr/09 7:56 PM

can you highlight the incidences of this that you have seen?

Show
Brett Porter added a comment - 21/Apr/09 7:56 PM can you highlight the incidences of this that you have seen?

People

  • Assignee:
    Unassigned
    Reporter:
    Christian Gruber
Vote (0)
Watch (0)

Dates

  • Created:
    29/Aug/06 4:52 PM
    Updated:
    16/Sep/09 5:14 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.