Continuum

Attached File: CONTINUUM-800-maven-user.patch

Implemented DefaultUserManager.java as well as edited som poms for dependencies. One question that came up is how do we handle PasswordEncoder?

-Added jsps
-Added a few config files such:
web.xml
xwork.xml
MavenUser.properties
extremecomponents.xml
extremecomponents.tld

-Lacking:
plexus integration
acegi integration

Applied both patches

File Attached: CONTINUUM-800-continuum-webapp.patch

I keep getting an NPE. It seems that the getPersistenceManager() method from DefaultUserManager returns a null. Is it a problem with injection from plexus?

Committed the patch.

However plexus injection is probably better done by using the plexus annotations as the other actions do

attached maven-user-model-testing.patch as a boilerplate for some maven-user-model testing. however the following jpox/jdo error is confounding me.

org.jpox.metadata.InvalidMetaDataException: Error in MetaData for field "group" in class "User" : this is declared as org.apache.maven.user.model.UserGroup with "persistence-modifier=none" yet has either "default-fetch-group=true" or "primary-key=true" specified! These should be false.
at org.jpox.metadata.AbstractPropertyMetaData.populate(AbstractPropertyMetaData.java:801)
at org.jpox.metadata.ClassMetaData.populatePropertyMetaData(ClassMetaData.java:349)
at org.jpox.metadata.ClassMetaData.populate(ClassMetaData.java:219)
at org.jpox.metadata.MetaDataManager.populateClassesInterfacesInFile(MetaDataManager.java:1235)
at org.jpox.metadata.MetaDataManager.loadMetaDataForClass(MetaDataManager.java:1357)
at org.jpox.metadata.MetaDataManager.getMetaDataForClassOrInterface(MetaDataManager.java:510)
at org.jpox.metadata.MetaDataManager.getMetaDataForClassInternal(MetaDataManager.java:471)
at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:354)
at org.jpox.metadata.MetaDataManager.getMetaDataForClass(MetaDataManager.java:340)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.getReferencedClasses(RDBMSManager.java:2510)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTables(RDBMSManager.java:2276)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTablesAndValidate(RDBMSManager.java:2573)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.run(RDBMSManager.java:2213)
at org.jpox.store.rdbms.RDBMSManager$MgmtTransaction.execute(RDBMSManager.java:2069)
at org.jpox.store.rdbms.RDBMSManager.addClasses(RDBMSManager.java:564)
at org.jpox.SchemaTool.createSchemaTables(SchemaTool.java:189)
at org.apache.maven.user.model.impl.DefaultUserManagerTest.setUp(DefaultUserManagerTest.java:80)
at junit.framework.TestCase.runBare(TestCase.java:125)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:128)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)

what I see in the branch is

16:09:00,140 ERROR JPOX.RDBMS.SCHEMA [org.jpox.store.rdbms.RDBMSManager] Failed initialising database. Exception : The class "org.apache.maven.continuum.model.system.ContinuumUser" is required to be Persistence-Capable yet no Meta-Data can be found for this class. Please check that the Meta-Data is defined in a valid file location for JDO.
org.jpox.exceptions.MetaDataForPersistenceCapableClassNotReachableException: The class "org.apache.maven.continuum.model.system.ContinuumUser" is required to be Persistence-Capable yet no Meta-Data can be found for this class. Please check that the Meta-Data is defined in a valid file location for JDO.
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.getReferencedClasses(RDBMSManager.java:2514)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTables(RDBMSManager.java:2276)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTablesAndValidate(RDBMSManager.java:2573)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.run(RDBMSManager.java:2213)
at org.jpox.store.rdbms.RDBMSManager$MgmtTransaction.execute(RDBMSManager.java:2069)
at org.jpox.store.rdbms.RDBMSManager.addClasses(RDBMSManager.java:564)
at org.jpox.store.StoreManager.initialiseAutoStart(StoreManager.java:407)
at org.jpox.store.rdbms.RDBMSManager.initialiseSchema(RDBMSManager.java:483)
at org.jpox.store.rdbms.RDBMSManager.<init>(RDBMSManager.java:242)
at org.jpox.store.rdbms.RDBMSManagerFactory.getStoreManager(RDBMSManagerFactory.java:59)
at org.jpox.AbstractPersistenceManager.<init>(AbstractPersistenceManager.java:222)
at org.jpox.PersistenceManagerImpl.<init>(PersistenceManagerImpl.java:34)
at org.jpox.PersistenceManagerFactoryImpl.getPersistenceManager(PersistenceManagerFactoryImpl.java:916)
at org.jpox.PersistenceManagerFactoryImpl.getPersistenceManager(PersistenceManagerFactoryImpl.java:891)
at org.apache.maven.continuum.store.JdoContinuumStore.getPersistenceManager(JdoContinuumStore.java:1295)
at org.apache.maven.continuum.store.JdoContinuumStore.updateObject(JdoContinuumStore.java:598)
at org.apache.maven.continuum.store.JdoContinuumStore.updateSystemConfiguration(JdoContinuumStore.java:1045)
at org.apache.maven.continuum.configuration.DefaultConfigurationService.store_aroundBody50(DefaultConfigurationService.java:266)
at org.apache.maven.continuum.configuration.DefaultConfigurationService.store(DefaultConfigurationService.java:1)
at org.apache.maven.continuum.DefaultContinuum.stopContinuum_aroundBody156(DefaultContinuum.java:2064)
at org.apache.maven.continuum.DefaultContinuum$AjcClosure157.run(DefaultContinuum.java:1)
at org.codehaus.plexus.acegi.intercept.method.aspectj.SecurityAspect.ajc$around$org_codehaus_plexus_acegi_intercept_method_aspectj_SecurityAspect$1$6563cc0cproceed(SecurityAspect.aj)
at org.codehaus.plexus.acegi.intercept.method.aspectj.SecurityAspect.ajc$around$org_codehaus_plexus_acegi_intercept_method_aspectj_SecurityAspect$1$6563cc0c(SecurityAspect.aj:66)
at org.apache.maven.continuum.DefaultContinuum.stopContinuum(DefaultContinuum.java:1)
at org.apache.maven.continuum.DefaultContinuum$1.run(DefaultContinuum.java:163)

Exception in thread "Thread-2" org.jpox.exceptions.MetaDataForPersistenceCapableClassNotReachableException: The class "org.apache.maven.continuum.model.system.ContinuumUser" is required to be Persistence-Capable yet no Meta-Data can be found for this class. Please check that the Meta-Data is defined in a valid file location for JDO.
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.getReferencedClasses(RDBMSManager.java:2514)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTables(RDBMSManager.java:2276)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.addClassTablesAndValidate(RDBMSManager.java:2573)
at org.jpox.store.rdbms.RDBMSManager$ClassAdder.run(RDBMSManager.java:2213)
at org.jpox.store.rdbms.RDBMSManager$MgmtTransaction.execute(RDBMSManager.java:2069)
at org.jpox.store.rdbms.RDBMSManager.addClasses(RDBMSManager.java:564)
at org.jpox.store.StoreManager.initialiseAutoStart(StoreManager.java:407)
at org.jpox.store.rdbms.RDBMSManager.initialiseSchema(RDBMSManager.java:483)
at org.jpox.store.rdbms.RDBMSManager.<init>(RDBMSManager.java:242)
at org.jpox.store.rdbms.RDBMSManagerFactory.getStoreManager(RDBMSManagerFactory.java:59)
at org.jpox.AbstractPersistenceManager.<init>(AbstractPersistenceManager.java:222)
at org.jpox.PersistenceManagerImpl.<init>(PersistenceManagerImpl.java:34)
at org.jpox.PersistenceManagerFactoryImpl.getPersistenceManager(PersistenceManagerFactoryImpl.java:916)
at org.jpox.PersistenceManagerFactoryImpl.getPersistenceManager(PersistenceManagerFactoryImpl.java:891)
at org.apache.maven.continuum.store.JdoContinuumStore.getPersistenceManager(JdoContinuumStore.java:1295)
at org.apache.maven.continuum.store.JdoContinuumStore.updateObject(JdoContinuumStore.java:598)
at org.apache.maven.continuum.store.JdoContinuumStore.updateSystemConfiguration(JdoContinuumStore.java:1045)
at org.apache.maven.continuum.configuration.DefaultConfigurationService.store_aroundBody50(DefaultConfigurationService.java:266)
at org.apache.maven.continuum.configuration.DefaultConfigurationService.store(DefaultConfigurationService.java:1)
at org.apache.maven.continuum.DefaultContinuum.stopContinuum_aroundBody156(DefaultContinuum.java:2064)
at org.apache.maven.continuum.DefaultContinuum$AjcClosure157.run(DefaultContinuum.java:1)
at org.codehaus.plexus.acegi.intercept.method.aspectj.SecurityAspect.ajc$around$org_codehaus_plexus_acegi_intercept_method_aspectj_SecurityAspect$1$6563cc0cproceed(SecurityAspect.aj)
at org.codehaus.plexus.acegi.intercept.method.aspectj.SecurityAspect.ajc$around$org_codehaus_plexus_acegi_intercept_method_aspectj_SecurityAspect$1$6563cc0c(SecurityAspect.aj:66)
at org.apache.maven.continuum.DefaultContinuum.stopContinuum(DefaultContinuum.java:1)
at org.apache.maven.continuum.DefaultContinuum$1.run(DefaultContinuum.java:163)

Attached a new patch for maven-user-model testing.
There's an odd error with UserGroup.getPermissions() that this testcase identifies, but I do not know how to fix it (yet).

javax.jdo.JDODetachedFieldAccessException: You have just attempted to access field "permissions" yet this field was not detached when you detached the object. Either dont access this field, or detach the field when detaching the object.
at org.apache.maven.user.model.UserGroup.jdoGetpermissions(UserGroup.java)
at org.apache.maven.user.model.UserGroup.getPermissions(UserGroup.java:112)
at org.apache.maven.user.model.impl.DefaultUserManagerTest.testGetSetPermissions(DefaultUserManagerTest.java:374)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)

Applied latest patch

Updated maven-user-model testing, documentation, and missing functionality.

See: CONTINUUM-800-maven-user-model-update-2.patch

patch applied

Attached CONTINUUM-800-maven-user-webapp-update-2.patch which fixes many compile and testing issues with maven-user-webapp.

Not perfect tho. as xwork<->plexus integration seems to not be working.

The EditUserAction does not get its UserManager set via plexus.

Just uploading this so others can work off it.

applied. It may be that it doesn't work standalone, but we have to get it working in continuum, and later in mrm

File Attached: CONTINUUM-800-continuum-acegi-branch.patch

This patch makes continuum use maven-user. ContinuumUser now extends the classes in maven-user-model.