jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Continuum
  • CONTINUUM-759

Generate plexus-request.xml with plexus-cdc

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 1.1-alpha-1
  • Fix Version/s: 1.1-alpha-1
  • Component/s: Web interface
  • Labels:
    None
  • Complexity:
    Intermediate
  • Options
    • Sort By Name
    • Sort By Date
    • Ascending
    • Descending
    • Download All

Attachments

  1. Text File
    CONTINUUM-759.patch
    13/Jul/06 2:58 PM
    35 kB
    Jesse McConnell
  2. Text File
    CONTINUUM-759+AbstractContinuumAction+formatting.patch
    14/Jul/06 7:39 AM
    46 kB
    Jesse McConnell

Issue Links

depends upon

Task - A task that needs to be done. CONTINUUM-758 Use plexus-cdc where it is possible for the generation of components.xml

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Trygve Laugstol added a comment - 06/Jul/06 5:34 PM

What is a plexus-request.xml?

Show
Trygve Laugstol added a comment - 06/Jul/06 5:34 PM What is a plexus-request.xml?
Hide
Permalink
Emmanuel Venisse added a comment - 06/Jul/06 6:04 PM

it's the plexus conf file used by plexus-xwork and that contains all resquest objects like actions.
Two other files are used by plexus-xwork: plexus-application.xml and plexus-session.xml

Show
Emmanuel Venisse added a comment - 06/Jul/06 6:04 PM it's the plexus conf file used by plexus-xwork and that contains all resquest objects like actions. Two other files are used by plexus-xwork: plexus-application.xml and plexus-session.xml
Hide
Permalink
Trygve Laugstol added a comment - 07/Jul/06 6:16 AM

I will have to think about this. How will the CDC/Plexus Maven Plugin know to tell the difference between a application, session and request component? Isn't that just how it's looked up? Also, what's the difference between plexus-application.xml and a normal components.xml?

Show
Trygve Laugstol added a comment - 07/Jul/06 6:16 AM I will have to think about this. How will the CDC/Plexus Maven Plugin know to tell the difference between a application, session and request component? Isn't that just how it's looked up? Also, what's the difference between plexus-application.xml and a normal components.xml?
Hide
Permalink
Emmanuel Venisse added a comment - 07/Jul/06 5:18 PM

CDC/Plexus Maven Plugin don't know the difference, it generate only the file we want :

{nofornat}

<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
<configuration>
<fileName>plexus-request.xml</fileName>
<containerDescriptor>true</containerDescriptor>
</configuration>
</plugin>


plexus-application.xml is similar to component.xml or the old continuum conf file (application.xml). In this file we add all component required by the webwork application and not session or request objects

Show
Emmanuel Venisse added a comment - 07/Jul/06 5:18 PM CDC/Plexus Maven Plugin don't know the difference, it generate only the file we want : {nofornat} <plugin> <groupId>org.codehaus.plexus</groupId> <artifactId>plexus-maven-plugin</artifactId> <configuration> <fileName>plexus-request.xml</fileName> <containerDescriptor>true</containerDescriptor> </configuration> </plugin>

plexus-application.xml is similar to component.xml or the old continuum conf file (application.xml). In this file we add all component required by the webwork application and not session or request objects
Hide
Permalink
Jesse McConnell added a comment - 13/Jul/06 2:58 PM

this replaces the static plexus-request.xml file with an automatically version of the same file

updated room pom plexus-maven-plugin version 1.3-SNAPSHOT

touched all the *Action files

added plexus-maven-plugin call to continuum-webapp pom

aligned the xwork.xml file with the generated plexus-request.xml file so role hints where consistent across the board

Show
Jesse McConnell added a comment - 13/Jul/06 2:58 PM this replaces the static plexus-request.xml file with an automatically version of the same file updated room pom plexus-maven-plugin version 1.3-SNAPSHOT touched all the *Action files added plexus-maven-plugin call to continuum-webapp pom aligned the xwork.xml file with the generated plexus-request.xml file so role hints where consistent across the board
Hide
Permalink
Jesse McConnell added a comment - 13/Jul/06 9:36 PM

err, in the continuum-webapp/pom.xml in that patch axe out the ${project.} bit, it doesn't need to be there

Show
Jesse McConnell added a comment - 13/Jul/06 9:36 PM err, in the continuum-webapp/pom.xml in that patch axe out the ${project.} bit, it doesn't need to be there
Hide
Permalink
Jesse McConnell added a comment - 13/Jul/06 10:37 PM

/Users/jesse/src/continuum-trunk/CONTINUUM-759+AbstractContinuumAction.patch

this patch includes all the other previous stuff, fixes the little mistake in the previous comment and also add something that emmanuel mentioned this morning when we were talking.

I added an AbstractContinuumAction class that implements LogEnabled and basically uses all the stuff from AbstractLogEnabled (since I couldn't extend both the required xwork ActionSupport and the AbstractLogEnabled. I setup all the Actions to use this as their baseclass and added in a test case to ensure the Action logging was working. This basically allows all of the actions to use the normal plexus getLogger().info("hi") type syntax for logging. This way we get to keep everything similar to the current plexus logging mechanism and can keep up with any improvements there.

Show
Jesse McConnell added a comment - 13/Jul/06 10:37 PM /Users/jesse/src/continuum-trunk/CONTINUUM-759+AbstractContinuumAction.patch this patch includes all the other previous stuff, fixes the little mistake in the previous comment and also add something that emmanuel mentioned this morning when we were talking. I added an AbstractContinuumAction class that implements LogEnabled and basically uses all the stuff from AbstractLogEnabled (since I couldn't extend both the required xwork ActionSupport and the AbstractLogEnabled. I setup all the Actions to use this as their baseclass and added in a test case to ensure the Action logging was working. This basically allows all of the actions to use the normal plexus getLogger().info("hi") type syntax for logging. This way we get to keep everything similar to the current plexus logging mechanism and can keep up with any improvements there.
Hide
Permalink
Emmanuel Venisse added a comment - 14/Jul/06 2:10 AM

the copyright in the abstract class is wrong.
I'd prefer to see plexus tags attributes indented like it's done in plexus docs : http://plexus.codehaus.org/ref/developer-guide/building-applications/cdc.html

Show
Emmanuel Venisse added a comment - 14/Jul/06 2:10 AM the copyright in the abstract class is wrong. I'd prefer to see plexus tags attributes indented like it's done in plexus docs : http://plexus.codehaus.org/ref/developer-guide/building-applications/cdc.html
Hide
Permalink
Jesse McConnell added a comment - 14/Jul/06 7:39 AM

/Users/jesse/src/continuum-trunk/CONTINUUM-759+AbstractContinuumAction+formatting.patch

+ the formatting emmanuel mentioned

Show
Jesse McConnell added a comment - 14/Jul/06 7:39 AM /Users/jesse/src/continuum-trunk/CONTINUUM-759+AbstractContinuumAction+formatting.patch + the formatting emmanuel mentioned
Hide
Permalink
Emmanuel Venisse added a comment - 14/Jul/06 3:25 PM

Applied. Thanks.

Show
Emmanuel Venisse added a comment - 14/Jul/06 3:25 PM Applied. Thanks.

People

  • Assignee:
    Jesse McConnell
    Reporter:
    Emmanuel Venisse
Vote (0)
Watch (0)

Dates

  • Created:
    06/Jul/06 11:28 AM
    Updated:
    14/Jul/06 3:25 PM
    Resolved:
    14/Jul/06 3:25 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.