Uploading pom file does not support projects with modules

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.0.3
  • Fix Version/s: Backlog
  • Component/s: Web interface
  • Labels:
    None
  • Environment:
    debian linux / ubuntu linux
  • Complexity:
    Intermediate

Description

Uploaded pom files cannot contain sub modules.

I see in issue CONTINUUM-425 that this is known, but it really should be possible to fix.
Can we not just read the scm and download before trying to read the child poms?

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. CONTINUUM-909 Can't upload M2 POM from local file sytem.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. CONTINUUM-1763 "Choose file" button to add multiple modules

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
supercedes

Improvement - An improvement or enhancement to an existing feature or task. CONTINUUM-1641 Allow to upload a Maven 2 POM with modules, if it's nonRecursive

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emmanuel Venisse added a comment -

I think we'll download all modules from scm.

Show
Emmanuel Venisse added a comment - I think we'll download all modules from scm.
Hide
Permalink
Olivier Lamy added a comment -

Attached patch.
As this can be long because a checkout must be done to extract all poms from modules, I think CONTINUUM-515 can be committed too.
Let me know, if yes I will provide an other patch with this.

–
Olivier

PS : I have added junit for ant project (adding project and build).

Show
Olivier Lamy added a comment - Attached patch. As this can be long because a checkout must be done to extract all poms from modules, I think CONTINUUM-515 can be committed too. Let me know, if yes I will provide an other patch with this. – Olivier PS : I have added junit for ant project (adding project and build).
Hide
Permalink
Olivier Lamy added a comment -

Do not apply this unit failed in core (MavenTwoContinuumProjectBuilderTest).
I have tested with the gui but I need to change some asserts because now continuum can download modules when reading a pom .

Show
Olivier Lamy added a comment - Do not apply this unit failed in core (MavenTwoContinuumProjectBuilderTest). I have tested with the gui but I need to change some asserts because now continuum can download modules when reading a pom .
Hide
Permalink
kyle northcutt added a comment -

We have a multi-module project that cannot be built by continuum because of this issue. If there is anyway we could get a build 1.1, 1.3 etc that includes this fix, we'd be ever grateful. We are willing to beta test if necessary.

Show
kyle northcutt added a comment - We have a multi-module project that cannot be built by continuum because of this issue. If there is anyway we could get a build 1.1, 1.3 etc that includes this fix, we'd be ever grateful. We are willing to beta test if necessary.
Hide
Permalink
Brett Porter added a comment -

we should at least improve the error message to indicate how to handle multi-module builds instead.

Show
Brett Porter added a comment - we should at least improve the error message to indicate how to handle multi-module builds instead.

People

  • Assignee:
    Unassigned
    Reporter:
    Andrew Williams
Vote (9)
Watch (6)

Dates

  • Created:
    Updated: