Continuum

Add a RecipientSource that derives addresses from the change list

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1-beta-3
  • Component/s: Notification Subsystem
  • Labels:
    None
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

CruiseControl has the nice feature of only sending notification email to those users who submitted the changes in the build. I missed that feature when switching to Continuum, so I implemented it. It compiles a list of scm ids from the change list, then matches them against the developers in the POM to get email addresses. It delegates to the default RecipientSource if there is no change list.

Issue Links

is duplicated by

New Feature - A new feature of the product, which has yet to be developed. CONTINUUM-560 Extend blame mechanism to send email to the developer that caused the build to fail

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Wish - General wishlist item CONTINUUM-715 Automatic notification to last committers

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Emmanuel Venisse made changes -
Field Original Value New Value
Fix Version/s 1.0.3 [ 12330 ]
Fix Version/s 1.1 [ 12082 ]
Emmanuel Venisse made changes -
Workflow jira [ 49633 ] Maven New [ 52656 ]
Emmanuel Venisse made changes -
Component/s Core system [ 10883 ]
Component/s Notification [ 12225 ]
Emmanuel Venisse made changes -
Link This issue is duplicated by CONTINUUM-560 [ CONTINUUM-560 ]
Emmanuel Venisse made changes -
Link This issue is duplicated by CONTINUUM-715 [ CONTINUUM-715 ]
Hide
Permalink
markus wahl added a comment -

Great work. But I don't understand how I should use it. What version of Continuum do I need? Do I need to turn the feature on somehow? How?

Show
markus wahl added a comment - Great work. But I don't understand how I should use it. What version of Continuum do I need? Do I need to turn the feature on somehow? How?
Hide
Permalink
John Didion added a comment -

Basically you just replace ContinuumRecipientSource with ChangeListRecipientSource in application.xml (found in apps/continuum/conf for an installed version of continuum). I developed against 1.0.2...not sure if it will work with later versions.

Show
John Didion added a comment - Basically you just replace ContinuumRecipientSource with ChangeListRecipientSource in application.xml (found in apps/continuum/conf for an installed version of continuum). I developed against 1.0.2...not sure if it will work with later versions.
John Didion made changes -
Attachment change-list-recipient-source.diff [ 23767 ]
Hide
Permalink
John Didion added a comment -

I've added a new diff against the 1.0.3 tag.

It would be idea if RecipientSources could be associated with notifiers (or at least notifier types) rather than just having one for the whole application. This involves a change to plexus, however.

Show
John Didion added a comment - I've added a new diff against the 1.0.3 tag. It would be idea if RecipientSources could be associated with notifiers (or at least notifier types) rather than just having one for the whole application. This involves a change to plexus, however.
Hide
Permalink
Brett Porter added a comment -

this is a good feature to add. Can we work with this patch to integrate it into Continuum so that it is a configuration option for a project, etc? Perhaps bring it up as a discussion point on continuum-dev@maven.apache.org?

Show
Brett Porter added a comment - this is a good feature to add. Can we work with this patch to integrate it into Continuum so that it is a configuration option for a project, etc? Perhaps bring it up as a discussion point on continuum-dev@maven.apache.org?
Jesse McConnell made changes -
Fix Version/s 1.1-alpha-2 [ 12960 ]
Fix Version/s 1.1-alpha-1 [ 12082 ]
Jesse McConnell made changes -
Fix Version/s 1.1-alpha-2 [ 12960 ]
Fix Version/s 1.1-alpha-3 [ 13432 ]
Emmanuel Venisse made changes -
Fix Version/s To Sort [ 13607 ]
Fix Version/s 1.1-beta-1 [ 13432 ]
Emmanuel Venisse made changes -
Fix Version/s Future [ 13292 ]
Fix Version/s To Sort [ 13607 ]
Brett Porter made changes -
Patch Submitted [Yes]
Hide
Permalink
nicolas de loof added a comment -

Is there any work in progress on this issue for continuum 1.1 ?
This feature is a requirement for me as a CruiseControl user. I'm also trying Hudson that provides this feature, but is not 100% maven2 compliant.

Show
nicolas de loof added a comment - Is there any work in progress on this issue for continuum 1.1 ? This feature is a requirement for me as a CruiseControl user. I'm also trying Hudson that provides this feature, but is not 100% maven2 compliant.
Hide
Permalink
Brett Porter added a comment -

I'll ping the dev list.

Show
Brett Porter added a comment - I'll ping the dev list.
Emmanuel Venisse made changes -
Fix Version/s To Sort [ 13607 ]
Fix Version/s Future [ 13292 ]
Hide
Permalink
Emmanuel Venisse added a comment -

I'll work on this issue but without the attached patch, I don't think it's the good way to resolve this issue.

I think the best way is to modify the mail notifier. Based on the notifier configuration, we'd can choose between to send mails to the specified address or committers (or eventually all project developers)

Show
Emmanuel Venisse added a comment - I'll work on this issue but without the attached patch, I don't think it's the good way to resolve this issue. I think the best way is to modify the mail notifier. Based on the notifier configuration, we'd can choose between to send mails to the specified address or committers (or eventually all project developers)
Emmanuel Venisse made changes -
Fix Version/s To Sort [ 13607 ]
Assignee Emmanuel Venisse [ evenisse ]
Fix Version/s 1.1-beta-3 [ 13661 ]
Hide
Permalink
Emmanuel Venisse added a comment -

Fixed in r.574675
I didn't use the attached patch

Show
Emmanuel Venisse added a comment - Fixed in r.574675 I didn't use the attached patch
Emmanuel Venisse made changes -
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Hide
Permalink
Luis Garcia added a comment -

I may be missing something, but it's not clear to me how to enable this feature.

Show
Luis Garcia added a comment - I may be missing something, but it's not clear to me how to enable this feature.

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    John Didion
Vote (11)
Watch (9)

Dates

  • Created:
    Updated:
    Resolved: