Issue Details (XML | Word | Printable)

Key: CONTINUUM-605
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Emmanuel Venisse
Reporter: John Didion
Votes: 11
Watchers: 9
Operations

If you were logged in you would be able to see more operations.
Continuum

Add a RecipientSource that derives addresses from the change list

Created: 23/Feb/06 09:17 PM   Updated: 27/Aug/08 08:41 PM   Resolved: 11/Sep/07 03:18 PM
Component/s: Notification Subsystem
Affects Version/s: None
Fix Version/s: 1.1-beta-3

Time Tracking:
Not Specified

File Attachments: 1. File change-list-recipient-source.diff (4 kB)
2. File ChangeListRecipientSource.diff (4 kB)

Issue Links:
Duplicate
 

Complexity: Intermediate
Patch Submitted: Yes


 Description  « Hide

CruiseControl has the nice feature of only sending notification email to those users who submitted the changes in the build. I missed that feature when switching to Continuum, so I implemented it. It compiles a list of scm ids from the change list, then matches them against the developers in the POM to get email addresses. It delegates to the default RecipientSource if there is no change list.



markus wahl added a comment - 15/Aug/06 06:32 AM

Great work. But I don't understand how I should use it. What version of Continuum do I need? Do I need to turn the feature on somehow? How?


John Didion added a comment - 21/Aug/06 05:32 PM

Basically you just replace ContinuumRecipientSource with ChangeListRecipientSource in application.xml (found in apps/continuum/conf for an installed version of continuum). I developed against 1.0.2...not sure if it will work with later versions.


John Didion added a comment - 01/Nov/06 05:29 PM

I've added a new diff against the 1.0.3 tag.

It would be idea if RecipientSources could be associated with notifiers (or at least notifier types) rather than just having one for the whole application. This involves a change to plexus, however.


Brett Porter added a comment - 26/Dec/06 07:24 PM

this is a good feature to add. Can we work with this patch to integrate it into Continuum so that it is a configuration option for a project, etc? Perhaps bring it up as a discussion point on continuum-dev@maven.apache.org?


nicolas de loof added a comment - 22/Aug/07 04:08 AM

Is there any work in progress on this issue for continuum 1.1 ?
This feature is a requirement for me as a CruiseControl user. I'm also trying Hudson that provides this feature, but is not 100% maven2 compliant.


Brett Porter added a comment - 22/Aug/07 04:25 AM

I'll ping the dev list.


Emmanuel Venisse added a comment - 03/Sep/07 08:16 AM

I'll work on this issue but without the attached patch, I don't think it's the good way to resolve this issue.

I think the best way is to modify the mail notifier. Based on the notifier configuration, we'd can choose between to send mails to the specified address or committers (or eventually all project developers)


Emmanuel Venisse added a comment - 11/Sep/07 03:18 PM

Fixed in r.574675
I didn't use the attached patch


Luis Garcia added a comment - 27/Aug/08 08:41 PM

I may be missing something, but it's not clear to me how to enable this feature.