Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.1
    • Fix Version/s: 1.4.1
    • Component/s: Distributed Builds
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      0

      Description

      Under the circumstances outlined in CONTINUUM-2655, the build result is never returned to the server. In this case, the server never times out waiting for the response, and further pings do not encourage the agent to present the failure.

      The build will run forever if it was forced and not respecting the timeout value. It can no longer be cancelled as it doesn't appear in the queue.

      Two things are needed:

      • A failure to respond should generate a new error response (with a simpler message less likely to fail)
      • The server should check for a lack of response and end the build if the job has finished

        Issue Links

          Activity

          Hide
          Maria Catherine Tan added a comment -

          I'd also like the cancel button on the build to note the build already ended and also be able to clean it up when pressed instead of waiting for the background job.

          I was planning to disable the cancel button on the build because if we have 2 builds running at the same time for the same project, we won't be able to determine which build do the user wants to cancel from the project group page.

          Show
          Maria Catherine Tan added a comment - I'd also like the cancel button on the build to note the build already ended and also be able to clean it up when pressed instead of waiting for the background job. I was planning to disable the cancel button on the build because if we have 2 builds running at the same time for the same project, we won't be able to determine which build do the user wants to cancel from the project group page.
          Hide
          Brett Porter added a comment -

          what conditions would you disable it? I don't see how "two builds" relates to "stuck building when nothing is"

          Show
          Brett Porter added a comment - what conditions would you disable it? I don't see how "two builds" relates to "stuck building when nothing is"
          Hide
          Maria Catherine Tan added a comment -

          Disable it if distributed build is enabled so user will have to cancel the build from the queues page.

          If there are 2 builds running (not stuck or anything) and the user click the cancel button, we can't determine which of those 2 builds to cancel.

          2 Builds:
          Project A : Build Definition A - Build Agent A
          Project A : Build Definition B - Build Agent B

          Show
          Maria Catherine Tan added a comment - Disable it if distributed build is enabled so user will have to cancel the build from the queues page. If there are 2 builds running (not stuck or anything) and the user click the cancel button, we can't determine which of those 2 builds to cancel. 2 Builds: Project A : Build Definition A - Build Agent A Project A : Build Definition B - Build Agent B
          Hide
          Maria Catherine Tan added a comment -

          I think we can just cancel all the builds of that project when cancel button is clicked.

          From the queues page, you can select which build you want to cancel.

          Show
          Maria Catherine Tan added a comment - I think we can just cancel all the builds of that project when cancel button is clicked. From the queues page, you can select which build you want to cancel.
          Hide
          Maria Catherine Tan added a comment -

          Revision r1162127

          • clicking cancel button will cancel all builds of project. However, it will not cancel a project build that is still doing scm update, it will just skip it.
          Show
          Maria Catherine Tan added a comment - Revision r1162127 clicking cancel button will cancel all builds of project. However, it will not cancel a project build that is still doing scm update, it will just skip it.

            People

            • Assignee:
              Maria Catherine Tan
              Reporter:
              Brett Porter
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: