Distributed build may never return

Actually, it seems in this case the error of CONTINUUM-2655 was received on the server and couldn't be parsed, which was returned to the agent, but not cleaned up on the server:

2011-08-23 18:13:02,927 [qtp169456094-176294] ERROR org.apache.xmlrpc.server.XmlRpcErrorLogger  - Failed to parse XML-RPC request: A
n invalid XML character (Unicode: 0xc) was found in the element content of the document.
org.apache.xmlrpc.XmlRpcException: Failed to parse XML-RPC request: An invalid XML character (Unicode: 0xc) was found in the element
 content of the document.
        at org.apache.xmlrpc.server.XmlRpcStreamServer.getRequest(XmlRpcStreamServer.java:71)
        at org.apache.xmlrpc.server.XmlRpcStreamServer.execute(XmlRpcStreamServer.java:199)
        at org.apache.xmlrpc.webserver.XmlRpcServletServer.execute(XmlRpcServletServer.java:112)
        at org.apache.xmlrpc.webserver.XmlRpcServlet.doPost(XmlRpcServlet.java:196)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)

Not sure if you can do an error handler for the XML-RPC request, or if the client needs to send a new one - but either way the description still applies.

potentially related issue, though it claims to be fixed

I think what we can do for here is to have a worker that will constantly checks if the builds are still active. If they are not active but state is still updating/building, then we assume that there must be some problem with the agent for it not to return the build result and then stops the build.

How is the queue populated at the moment? I notice that is correct so must be querying the agents - I would assume this does the same thing.

I'd also like the cancel button on the build to note the build already ended and also be able to clean it up when pressed instead of waiting for the background job.

Rev -r1161980

• added a worker that will check every minute if builds are still active. if builds are no longer active it will end the build and create a build result if the state was building or update the project's scm root if the state was updating.

How is the queue populated at the moment? I notice that is correct so must be querying the agents - I would assume this does the same thing.

Yes we are querying the agents. When a build is triggered, master determines which agent is available to build the project then pass the build to that agent where it will be queued.

I'd also like the cancel button on the build to note the build already ended and also be able to clean it up when pressed instead of waiting for the background job.

I was planning to disable the cancel button on the build because if we have 2 builds running at the same time for the same project, we won't be able to determine which build do the user wants to cancel from the project group page.

what conditions would you disable it? I don't see how "two builds" relates to "stuck building when nothing is"

Disable it if distributed build is enabled so user will have to cancel the build from the queues page.

If there are 2 builds running (not stuck or anything) and the user click the cancel button, we can't determine which of those 2 builds to cancel.

2 Builds:
Project A : Build Definition A - Build Agent A
Project A : Build Definition B - Build Agent B

I think we can just cancel all the builds of that project when cancel button is clicked.

From the queues page, you can select which build you want to cancel.

Revision r1162127

• clicking cancel button will cancel all builds of project. However, it will not cancel a project build that is still doing scm update, it will just skip it.