Include in webservice to also return platform of buildagent when retrieving a buildagent or list of buildagents

attaching patch for issue.

thanks.

Hi Mark, please see comments below:

Index: continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java
===================================================================
— continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java (revision 1054517)
+++ continuum-xmlrpc/continuum-xmlrpc-server/src/main/java/org/apache/maven/continuum/xmlrpc/server/ContinuumServiceImpl.java (working copy)
@@ -2201,9 +2201,21 @@

private BuildAgentConfiguration populateBuildAgent( org.apache.continuum.configuration.BuildAgentConfiguration buildAgent )
{

• return (BuildAgentConfiguration) mapper.map( buildAgent, BuildAgentConfiguration.class );
  + BuildAgentConfiguration buildAgentConfiguration =
  + (BuildAgentConfiguration) mapper.map( buildAgent, BuildAgentConfiguration.class );
  + try
  +
  Unknown macro: { + buildAgentConfiguration.setPlatform( distributedBuildManager.getbuildAgentPlatform( buildAgentConfiguration.getUrl() ) ); + return buildAgentConfiguration; + }

  + catch ( ContinuumException e )
  +

  Unknown macro: { + buildAgentConfiguration.setPlatform( "" ); + return buildAgentConfiguration; + }

  }

• Can you log the error/exception being swallowed when getting the build agent's platform?

Index: continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java
===================================================================
— continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java (revision 1054517)
+++ continuum-api/src/main/java/org/apache/continuum/builder/distributed/manager/DistributedBuildManager.java (working copy)
@@ -48,6 +48,9 @@

List<Installation> getAvailableInstallations( String buildAgentUrl )
throws ContinuumException;
+
+ String getbuildAgentPlatform( String buildAgentUrl )
+ throws ContinuumException;

• Can you make the method name camel-cased (e.g. getBuildAgentPlatform(...) )?
• Can you also provide unit tests for new method you added for the distributed build manager?

Thanks!

applied comments and uploading updated patch

thanks

Thanks Mark! Patch applied to Continuum trunk in -r1055810.

Maybe we can also display the build agent's platform from Continuum? Just read-only though, since it is auto-discovered.