Continuum

Webservice for getting platform of build agent

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.4.1
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    2

Description

Right now we don't have a web service expose for build agent in retrieving it's platform. It would be useful to have this feature to prepare for future implementation that would involve sorting build agents by platforms.

  1. Text File
    CONTINUUM-2597.patch
    14/Dec/10 4:23 AM
    27 kB
    Mark John Kenedy L. Magallanes
  2. Text File
    CONTINUUM-2597(new).patch
    14/Dec/10 10:56 AM
    10 kB
    Mark John Kenedy L. Magallanes

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mark John Kenedy L. Magallanes added a comment -

Upload Patch for issue
add implementation to get platform and expose it on the web service.

Show
Mark John Kenedy L. Magallanes added a comment - Upload Patch for issue add implementation to get platform and expose it on the web service.
Hide
Permalink
Wendy Smoak added a comment -

The patch has a lot of noise (reformatting/whitespace changes) that makes it difficult to see what you're actually changing.

(Do we have standard code style settings available for contributors?)

Can you please add some documentation explaining what this method returns?

I think I also saw a TODO in there and a method returning null... did something get left out?

Show
Wendy Smoak added a comment - The patch has a lot of noise (reformatting/whitespace changes) that makes it difficult to see what you're actually changing. (Do we have standard code style settings available for contributors?) Can you please add some documentation explaining what this method returns? I think I also saw a TODO in there and a method returning null... did something get left out?
Hide
Permalink
Mark John Kenedy L. Magallanes added a comment -

Uploaded an improved patch.

The method returns the value of System.getProperty( "os.name" ).

I'm sorry about the 1st patch I got used to pressing ctrl + shift + f when coding
this is now a clearer patch and also for my code formatter I am using the maven
profile.

Show
Mark John Kenedy L. Magallanes added a comment - Uploaded an improved patch. The method returns the value of System.getProperty( "os.name" ). I'm sorry about the 1st patch I got used to pressing ctrl + shift + f when coding this is now a clearer patch and also for my code formatter I am using the maven profile.
Hide
Permalink
Maria Catherine Tan added a comment -

Applied patch in r1049444

Thanks Mark!

Show
Maria Catherine Tan added a comment - Applied patch in r1049444 Thanks Mark!

People

  • Assignee:
    Maria Catherine Tan
    Reporter:
    Mark John Kenedy L. Magallanes
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: