Continuum
  1. Continuum
  2. CONTINUUM-2597

Webservice for getting platform of build agent

    Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      2

      Description

      Right now we don't have a web service expose for build agent in retrieving it's platform. It would be useful to have this feature to prepare for future implementation that would involve sorting build agents by platforms.

      1. CONTINUUM-2597.patch
        27 kB
        Mark John Kenedy L. Magallanes
      2. CONTINUUM-2597(new).patch
        10 kB
        Mark John Kenedy L. Magallanes

        Activity

        Hide
        Mark John Kenedy L. Magallanes added a comment -

        Upload Patch for issue
        add implementation to get platform and expose it on the web service.

        Show
        Mark John Kenedy L. Magallanes added a comment - Upload Patch for issue add implementation to get platform and expose it on the web service.
        Hide
        Wendy Smoak added a comment -

        The patch has a lot of noise (reformatting/whitespace changes) that makes it difficult to see what you're actually changing.

        (Do we have standard code style settings available for contributors?)

        Can you please add some documentation explaining what this method returns?

        I think I also saw a TODO in there and a method returning null... did something get left out?

        Show
        Wendy Smoak added a comment - The patch has a lot of noise (reformatting/whitespace changes) that makes it difficult to see what you're actually changing. (Do we have standard code style settings available for contributors?) Can you please add some documentation explaining what this method returns? I think I also saw a TODO in there and a method returning null... did something get left out?
        Hide
        Mark John Kenedy L. Magallanes added a comment -

        Uploaded an improved patch.

        The method returns the value of System.getProperty( "os.name" ).

        I'm sorry about the 1st patch I got used to pressing ctrl + shift + f when coding
        this is now a clearer patch and also for my code formatter I am using the maven
        profile.

        Show
        Mark John Kenedy L. Magallanes added a comment - Uploaded an improved patch. The method returns the value of System.getProperty( "os.name" ). I'm sorry about the 1st patch I got used to pressing ctrl + shift + f when coding this is now a clearer patch and also for my code formatter I am using the maven profile.
        Hide
        Maria Catherine Tan added a comment -

        Applied patch in r1049444

        Thanks Mark!

        Show
        Maria Catherine Tan added a comment - Applied patch in r1049444 Thanks Mark!

          People

          • Assignee:
            Maria Catherine Tan
            Reporter:
            Mark John Kenedy L. Magallanes
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: