Continuum
  1. Continuum
  2. CONTINUUM-2592

Ability for build agent to use installations in its config file

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.1
    • Component/s: Distributed Builds
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Description

      Currently build agents have their own installations in the config file continuum-buildagent.xml but the agent doesn't use them, instead the agent use the installations in the build environment attached to it.

      Build agent should use the installations in its config file.

      1. CONTINUUM-2592.patch
        14 kB
        Marc Jansen Tan Chua

        Activity

        Hide
        Wendy Smoak added a comment -

        Can you explain a bit more about what's going wrong here? I don't think I understand how it's working now and what you want to change.

        Show
        Wendy Smoak added a comment - Can you explain a bit more about what's going wrong here? I don't think I understand how it's working now and what you want to change.
        Hide
        Marc Jansen Tan Chua added a comment -

        Hello Wendy!!

        Currently, the "build agents" are grouped in "build agent groups" and use "installations" from their "build environments" during building, the improvement is to make "build agents" utilize their individual "installations" configured in "continuum-build-agents.xml".

        Show
        Marc Jansen Tan Chua added a comment - Hello Wendy!! Currently, the "build agents" are grouped in "build agent groups" and use "installations" from their "build environments" during building, the improvement is to make "build agents" utilize their individual "installations" configured in "continuum-build-agents.xml".
        Hide
        Marc Jansen Tan Chua added a comment -

        Took a while for me to trace the installation usage of build agents during the build process, it was encapsulated in so many layers

        Implementation proposal:

        There's a method to trigger the build and a method to select which agent to use, the methods are pretty much overloaded, so from those methods, I'll improve them to include the installations from the build agent's xml config file, I'll re-use the getter method that is used in displaying the individual set of installations per build agents.

        I'm still currently mapping out the whole encapsulated layer to see which layer is to be added with the enhancement to cater to extensibility & scalability


        -CHUABLE

        Show
        Marc Jansen Tan Chua added a comment - Took a while for me to trace the installation usage of build agents during the build process, it was encapsulated in so many layers Implementation proposal: There's a method to trigger the build and a method to select which agent to use, the methods are pretty much overloaded, so from those methods, I'll improve them to include the installations from the build agent's xml config file, I'll re-use the getter method that is used in displaying the individual set of installations per build agents. I'm still currently mapping out the whole encapsulated layer to see which layer is to be added with the enhancement to cater to extensibility & scalability -CHUABLE
        Hide
        Marc Jansen Tan Chua added a comment -

        Patch for CONTINUUM-2592

        Added 2 new Test Methods in Build Agent Core's BuildProjectTaskExecutorTest.java

        • testBuildProjectWithConfiguredInstallationsFromBuildAgent << 1
        • testBuildProjectWithNoConfiguredInstallationsFromBuildAgent << 2
        • Created some factory methods for dummy objects used in unit testing

        Improved fetching environments in Build Agent Core's BuildProjectTaskExecutor.java

        • Combines the configured environments from the Continuum Master with the configured environments from the Build Agent
        • Build Agent's Installation will overlap those installations that are in conflict with the ones in ContinuumMaster
        Show
        Marc Jansen Tan Chua added a comment - Patch for CONTINUUM-2592 Added 2 new Test Methods in Build Agent Core's BuildProjectTaskExecutorTest.java testBuildProjectWithConfiguredInstallationsFromBuildAgent << 1 testBuildProjectWithNoConfiguredInstallationsFromBuildAgent << 2 Created some factory methods for dummy objects used in unit testing Improved fetching environments in Build Agent Core's BuildProjectTaskExecutor.java Combines the configured environments from the Continuum Master with the configured environments from the Build Agent Build Agent's Installation will overlap those installations that are in conflict with the ones in ContinuumMaster
        Hide
        Maria Catherine Tan added a comment -

        Patch applied in r1049398

        Thanks Marc!

        Show
        Maria Catherine Tan added a comment - Patch applied in r1049398 Thanks Marc!

          People

          • Assignee:
            Maria Catherine Tan
            Reporter:
            Maria Catherine Tan
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: