Continuum

https:// doesn't seem to be a supported mechanism for referencing a pom

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0-alpha-4
  • Component/s: Web interface
  • Labels:
    None
  • Number of attachments :
    6

Description

I have a svn repository setup with https:// certificate and AD LDAP password authentication...

would be real nice to be able to point to a pom with

https://svn.company.com/svn/g-maven-plugins/trunk/pom.xml

and have it picked up.

right now it just grumbles about

Enter the URL to the Maven 2 POM [ The URL you provided doesn't exist ] (in red even

Attachments

  1. Java Source File
    MungedHttpsURL.java
    25/Aug/05 2:32 PM
    6 kB
    chisisi
  2. Text File
    secure-url-continuum-api.patch
    25/Aug/05 3:01 PM
    3 kB
    chisisi
  3. Text File
    secure-url-continuum-core.patch
    25/Aug/05 3:01 PM
    8 kB
    chisisi
  4. Text File
    secure-url-continuum-pre.patch
    24/Aug/05 9:10 AM
    17 kB
    chisisi
  5. Text File
    secure-url-plexus.patch
    25/Aug/05 3:01 PM
    3 kB
    chisisi
  6. Text File
    secure-url-validation.patch
    22/Aug/05 4:53 PM
    5 kB
    chisisi

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Emmanuel Venisse added a comment -

https is supported, the pb is with authentication.

Can you try with an url like https://username:password@svn.company.com/svn/g-maven-plugins/trunk/pom.xml ?

Show
Emmanuel Venisse added a comment - https is supported, the pb is with authentication. Can you try with an url like https://username:password@svn.company.com/svn/g-maven-plugins/trunk/pom.xml ?
Hide
Permalink
chisisi added a comment -

shoot, no dice on that approach

[ You must provide a valid url ]

password has a * in it though so that might be borking it as well..

Show
chisisi added a comment - shoot, no dice on that approach [ You must provide a valid url ] password has a * in it though so that might be borking it as well..
Hide
Permalink
chisisi added a comment -

this is an attempt at a patch for this issue on the plexis UrlSourceValidator

I couldn't locate the mechanism that plexus would use for a cleaner way of obtaining url, username and password from the https:// url string so I added a couple of scrapeX methods to the bottom.

it builds in plexus-formica just fine...I haven't tried it yet with my continuum build but I built it from the commandline testing version I was playing with to get the things right should it should be good to go.

I looked into adding to the test class for it but I don't know the policy for locating a https:// box for general testing of it.

just grab me on irc or email if you have questions or want me to revisit parts of it. it did dirty up a pretty simple class to get it worked around.

Show
chisisi added a comment - this is an attempt at a patch for this issue on the plexis UrlSourceValidator I couldn't locate the mechanism that plexus would use for a cleaner way of obtaining url, username and password from the https:// url string so I added a couple of scrapeX methods to the bottom. it builds in plexus-formica just fine...I haven't tried it yet with my continuum build but I built it from the commandline testing version I was playing with to get the things right should it should be good to go. I looked into adding to the test class for it but I don't know the policy for locating a https:// box for general testing of it. just grab me on irc or email if you have questions or want me to revisit parts of it. it did dirty up a pretty simple class to get it worked around.
Hide
Permalink
chisisi added a comment -

/home/jesse/osrc/continuum/secure-url-continuum-pre.patch

this is just a initial dump of what I had to do to get things working for review so I can clean things up nicely for a real patch

Show
chisisi added a comment - /home/jesse/osrc/continuum/secure-url-continuum-pre.patch this is just a initial dump of what I had to do to get things working for review so I can clean things up nicely for a real patch
Hide
Permalink
Brett Porter added a comment -

bringing forward since there is a patch

Show
Brett Porter added a comment - bringing forward since there is a patch
Hide
Permalink
chisisi added a comment -

I am in the process of creating a plexus-url-http component that wraps this functionality into MungedHttpsURL...leaving us the chance to do a better solution in DefaultHttpsURL down the road that prompts the user for cert acceptance and username/password..It is pretty close to done I think, will need to play around getting it plugged in bit should be a much cleaner patch coming once I get a few hours...hopefully this week

Show
chisisi added a comment - I am in the process of creating a plexus-url-http component that wraps this functionality into MungedHttpsURL...leaving us the chance to do a better solution in DefaultHttpsURL down the road that prompts the user for cert acceptance and username/password..It is pretty close to done I think, will need to play around getting it plugged in bit should be a much cleaner patch coming once I get a few hours...hopefully this week
Hide
Permalink
chisisi added a comment -

/home/jesse/osrc/plexus/secure-url.patch

this patchs in the usage of the file I'll be attaching next for resolution of funky secure urls

Show
chisisi added a comment - /home/jesse/osrc/plexus/secure-url.patch this patchs in the usage of the file I'll be attaching next for resolution of funky secure urls
Hide
Permalink
chisisi added a comment -

/home/jesse/osrc/plexus/plexus-components/plexus-formica/src/main/java/org/codehaus/plexus/formica/util/MungedHttpsURL.java

object for dealing with munged URL's of the format https://u:p@host.com/bar

Show
chisisi added a comment - /home/jesse/osrc/plexus/plexus-components/plexus-formica/src/main/java/org/codehaus/plexus/formica/util/MungedHttpsURL.java object for dealing with munged URL's of the format https://u:p@host.com/bar
Hide
Permalink
chisisi added a comment -

/home/jesse/osrc/plexus/secure-url-plexus.patch

used in combination with the MungedHttpsURL file attached

/home/jesse/osrc/continuum/secure-url-continuum-api.patch

includes pom.xml addition to add the plexus-formica package as a dependency for the new class

/home/jesse/osrc/continuum/secure-url-continuum-core.patch

includes pom.xml addition to add the plexus-formica package as a dependency for the new class

in all cases the change to the interface has forces changes in a number of unit tests which are as included and all still validates locally (given the patch into plexus)

There was talk about new components, or different ways to solve the problem, but this at least gets the change in a fairly nonintrusive manner..if someone wants me to look into building out a different type of component or mechanism then let me know.

cheers

Show
chisisi added a comment - /home/jesse/osrc/plexus/secure-url-plexus.patch used in combination with the MungedHttpsURL file attached /home/jesse/osrc/continuum/secure-url-continuum-api.patch includes pom.xml addition to add the plexus-formica package as a dependency for the new class /home/jesse/osrc/continuum/secure-url-continuum-core.patch includes pom.xml addition to add the plexus-formica package as a dependency for the new class in all cases the change to the interface has forces changes in a number of unit tests which are as included and all still validates locally (given the patch into plexus) There was talk about new components, or different ways to solve the problem, but this at least gets the change in a fairly nonintrusive manner..if someone wants me to look into building out a different type of component or mechanism then let me know. cheers
Hide
Permalink
chisisi added a comment -

attachments from the 25th are the ones that ought to be good to go, the others were for review and whatnot

Show
chisisi added a comment - attachments from the 25th are the ones that ought to be good to go, the others were for review and whatnot
Hide
Permalink
Emmanuel Venisse added a comment -

Applied. Thanks.

Show
Emmanuel Venisse added a comment - Applied. Thanks.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.