Continuum
  1. Continuum
  2. CONTINUUM-2532

Editing Build Definition doesn't reflect changes when saved

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0 (Beta)
    • Fix Version/s: 1.4.1
    • Component/s: None
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      0

      Description

      Steps to replicate:

      1. Add a new build definition to a project group with "Always Build" and "Build Fresh" set to TRUE. Click save.
      2. Build definitions page is shown with new entry. Click on edit.
      3. Set "Always Build" to FALSE and click save.
      4. Build definitions page is shown but the value is still TRUE
      5. Click on edit again, and the box is unchecked. Set "Build Fresh" to FALSE, and click save.
      6. Build definitions page is shown with both values now FALSE.

        Issue Links

          Activity

          Hide
          Maria Catherine Tan added a comment -

          If Build Fresh is true, it means it will always build. So having a build fresh set to true and always build to false is confusing.

          I think if Build Fresh is true, the always build should be set to true and disabled.

          Show
          Maria Catherine Tan added a comment - If Build Fresh is true, it means it will always build. So having a build fresh set to true and always build to false is confusing. I think if Build Fresh is true, the always build should be set to true and disabled.
          Hide
          Jevica Arianne B. Zurbano added a comment -

          Hi Catherine,

          IIRC, "Always Build" executes the project build even if there are no changes to the project which I think is used during scheduled builds.
          And, "Build Fresh" checks out a copy of the project whenever the build is triggered.

          So I think it is possible to set "Build Fresh" to TRUE and "Always Build" to FALSE.

          Show
          Jevica Arianne B. Zurbano added a comment - Hi Catherine, IIRC, "Always Build" executes the project build even if there are no changes to the project which I think is used during scheduled builds. And, "Build Fresh" checks out a copy of the project whenever the build is triggered. So I think it is possible to set "Build Fresh" to TRUE and "Always Build" to FALSE.
          Hide
          Maria Catherine Tan added a comment - - edited

          Yes, but if it's a build fresh, Continuum "always build" the project even if it's a scheduled build.

          IMO, saying that you want to have a build fresh but not build it will just cause confusion. The user might wonder why the project build when they set always build to false.

          FYI, Continuum first checks the BUILD FRESH before it checks the ALWAYS BUILD.

          Show
          Maria Catherine Tan added a comment - - edited Yes, but if it's a build fresh, Continuum "always build" the project even if it's a scheduled build. IMO, saying that you want to have a build fresh but not build it will just cause confusion. The user might wonder why the project build when they set always build to false. FYI, Continuum first checks the BUILD FRESH before it checks the ALWAYS BUILD.
          Hide
          Maria Catherine Tan added a comment -

          You're correct that "Build Fresh" will remove the directory and checks out a new copy of the project whenever the build is triggered.

          But Continuum will also check "Build Fresh" when trying to determine if project should build or not.

          See DefaultBuildController#shouldBuild

          Show
          Maria Catherine Tan added a comment - You're correct that "Build Fresh" will remove the directory and checks out a new copy of the project whenever the build is triggered. But Continuum will also check "Build Fresh" when trying to determine if project should build or not. See DefaultBuildController#shouldBuild
          Hide
          Jevica Arianne B. Zurbano added a comment -

          Thanks for clarifying, Catherine.

          Probably the behavior needs to be documented, wdyt?

          Show
          Jevica Arianne B. Zurbano added a comment - Thanks for clarifying, Catherine. Probably the behavior needs to be documented, wdyt?
          Hide
          Maria Catherine Tan added a comment -

          Yes! I'll do that in this fix.

          Thanks Jev!

          Show
          Maria Catherine Tan added a comment - Yes! I'll do that in this fix. Thanks Jev!
          Hide
          Maria Catherine Tan added a comment -

          Fixed in r951289

          • set 'Always Build' to true and disable it when 'Build Fresh' is checked
          • set 'Always Build' to false and enable it when 'Build Fresh' is unchecked
          • document that checking 'Build Fresh' will always build the project
          Show
          Maria Catherine Tan added a comment - Fixed in r951289 set 'Always Build' to true and disable it when 'Build Fresh' is checked set 'Always Build' to false and enable it when 'Build Fresh' is unchecked document that checking 'Build Fresh' will always build the project

            People

            • Assignee:
              Maria Catherine Tan
              Reporter:
              Marecor M. Baclay
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: