Continuum
  1. Continuum
  2. CONTINUUM-2458

Continuum Release should do a checkout if there is no working copy

    Details

    • Complexity:
      Intermediate
    • Number of attachments :
      2

      Description

      Rather than requiring an existing working copy, Continuum Release should be able to do a checkout if there is no working copy present for the project being released.

      1. CONTINUUM-2458.patch
        3 kB
        Gwen Harold Autencio
      2. unit-test-CONTINUUM-2458.patch
        3 kB
        Gwen Harold Autencio

        Issue Links

          Activity

          Hide
          Wendy Smoak added a comment -

          CONTINUUM-2457 will have to be resolved first. Right now not only must there be an existing working copy, but the most recent build result must be a success before you are allowed to begin a release.

          Show
          Wendy Smoak added a comment - CONTINUUM-2457 will have to be resolved first. Right now not only must there be an existing working copy, but the most recent build result must be a success before you are allowed to begin a release.
          Show
          Jevica Arianne B. Zurbano added a comment - - edited As proposed in dev@ list, this issue will not depend on CONTINUUM-2457 http://old.nabble.com/Thoughts-on-build-environment-selection-when-releasing-in-distributed-build-setup-td27399430i20.html
          Hide
          Gwen Harold Autencio added a comment -

          Hi,

          attaching patch for this issue.

          Show
          Gwen Harold Autencio added a comment - Hi, attaching patch for this issue.
          Hide
          Gwen Harold Autencio added a comment -

          I'll follow the unit test for this patch shortly.
          Thanks

          Show
          Gwen Harold Autencio added a comment - I'll follow the unit test for this patch shortly. Thanks
          Hide
          Jevica Arianne B. Zurbano added a comment -

          Thanks Gwen!

          BTW, I think it should be "checkOutScmResult" instead of "updateScmResult" for the following snippet, am I correct?

          +        else
          +        {
          +            if( !checkOutScmResult.isSuccess() )
          +            {
          +                throw new ReleaseScmCommandException( "Unable to checkout project", updateScmResult );
          +            }
          +            
          +            copyUpdated = checkOutScmResult.getCheckedOutFiles().size() > 0; 
          +        }
          
          Show
          Jevica Arianne B. Zurbano added a comment - Thanks Gwen! BTW, I think it should be "checkOutScmResult" instead of "updateScmResult" for the following snippet, am I correct? + else + { + if( !checkOutScmResult.isSuccess() ) + { + throw new ReleaseScmCommandException( "Unable to checkout project", updateScmResult ); + } + + copyUpdated = checkOutScmResult.getCheckedOutFiles().size() > 0; + }
          Hide
          Gwen Harold Autencio added a comment -

          Hi Jevica,

          Sorry that should have been "checkOutScmResult".
          Attaching unit test for patch thanks.

          Show
          Gwen Harold Autencio added a comment - Hi Jevica, Sorry that should have been "checkOutScmResult". Attaching unit test for patch thanks.
          Hide
          Jevica Arianne B. Zurbano added a comment -

          Patch applied in r928579.

          • checkout project if working directory does not exist
          • unit test for non-existing working directory

          I also added unit tests for working directory with project checkout and empty working directory.

          Thanks Gwen!

          Show
          Jevica Arianne B. Zurbano added a comment - Patch applied in r928579. checkout project if working directory does not exist unit test for non-existing working directory I also added unit tests for working directory with project checkout and empty working directory. Thanks Gwen!

            People

            • Assignee:
              Jevica Arianne B. Zurbano
              Reporter:
              Wendy Smoak
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: