Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.3.4 (Beta)
-
Fix Version/s: 1.4.0 (Beta)
-
Component/s: None
-
Labels:None
-
Complexity:Intermediate
-
Number of attachments :
Description
Steps to reproduce:
- Add a local repository named "DEFAULT" (with a space at the beginning and/or at the end of the name).
- View the list of Local Repositories
Actual behavior:
- The added local repository also appears to be the DEFAULT local repository resulting to multiple DEFAULT local repositories in the list.
Wherein, it is not possible to edit/delete the one which was added.
Expected Behavior:
- It should be possible to edit or delete the added local repository.
Activity
Hide
Jevica Arianne B. Zurbano
added a comment -
Patch applied in r907163 with the following modifications:
- trim repository name and location when comparing for duplicates and before saving. I moved all the trim() of the values in webapp instead of having it also in core (DefaultRepositoryService) from the patch submitted.
- added selenium test on adding duplicate repository with trailing spaces; adjusted the dependsOnMethods of the tests
Thanks, Garry! 
Show
Jevica Arianne B. Zurbano
added a comment - Patch applied in r907163 with the following modifications:
trim repository name and location when comparing for duplicates and before saving. I moved all the trim() of the values in webapp instead of having it also in core (DefaultRepositoryService) from the patch submitted.
added selenium test on adding duplicate repository with trailing spaces; adjusted the dependsOnMethods of the tests
Thanks, Garry!
The behavior I would expect here is that leading and trailing spaces would be stripped, and it would not allow you to add what is now a duplicate local repo.