Continuum

Master should not pass full path to local repository to the agent

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3.4 (Beta)
  • Fix Version/s: 1.4.0 (Beta)
  • Component/s: Distributed Builds
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

Currently the master for distributed build passes the full path to the local repository to the agent.

Brett said this is a security issue and suggested that local repos be identified by keys instead.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. CONTINUUM-2390 Unable to build on different platforms with distributed build

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Maria Odea Ching added a comment -

Made the following changes in -r924833:

  • pass repo name to build agent instead of full path
  • added support for local repos in build agent config file + tests
Show
Maria Odea Ching added a comment - Made the following changes in -r924833: pass repo name to build agent instead of full path added support for local repos in build agent config file + tests
Hide
Permalink
Maria Odea Ching added a comment -

What still needs to be done here:

  • pass repo name to build agent instead of full path when releasing projects using distributed builds
  • update documentation of the changes made
Show
Maria Odea Ching added a comment - What still needs to be done here: pass repo name to build agent instead of full path when releasing projects using distributed builds update documentation of the changes made
Hide
Permalink
Maria Odea Ching added a comment -

Committed unit test for the previous changes made in BuildProjectTaskExecutor in -r926018.

Show
Maria Odea Ching added a comment - Committed unit test for the previous changes made in BuildProjectTaskExecutor in -r926018.
Hide
Permalink
Maria Odea Ching added a comment -

Additional fixes committed to trunk -r926634 with the following changes:

  • pass only the repository name/id from the build server to the build agent during release
  • add tests for local repo path in release prepare and release perform with distributed builds
  • moved stub classes used for tests to its own package
Show
Maria Odea Ching added a comment - Additional fixes committed to trunk -r926634 with the following changes: pass only the repository name/id from the build server to the build agent during release add tests for local repo path in release prepare and release perform with distributed builds moved stub classes used for tests to its own package
Hide
Permalink
Maria Odea Ching added a comment -

Updated Continuum docs with the changes in the behavior due to the above fixes in -r926929.

Show
Maria Odea Ching added a comment - Updated Continuum docs with the changes in the behavior due to the above fixes in -r926929 .
Hide
Permalink
Maria Odea Ching added a comment -

Added changes to build agent's config file to trunk -r931464

Show
Maria Odea Ching added a comment - Added changes to build agent's config file to trunk -r931464

People

  • Assignee:
    Maria Odea Ching
    Reporter:
    Wendy Smoak
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: