Continuum
  1. Continuum
  2. CONTINUUM-2281

Same Recipiant will be added several times in Notification

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.3 (Beta), 1.3.4 (Beta)
    • Fix Version/s: 1.3.4 (Beta)
    • Labels:
      None
    • Environment:
      Windows, Tomcat, JDK 5, Subversion
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Description

      If notifier configuration is committers = true, then for each SCM change the Author is added in To Address. Even if the Author is already a Recipient. The Author will only get one email, but the To Address will get right long.

      http://svn.apache.org/repos/asf/continuum/tags/continuum-1.3.3/continuum-core/src/main/java/org/apache/maven/continuum/notification/mail/MailContinuumNotifier.java

      for ( ChangeSet changeSet : changes )
      {
      String scmId = changeSet.getAuthor();
      if ( StringUtils.isNotEmpty( scmId ) )
      {
      String email = developerToEmailMap.get( scmId );
      if ( StringUtils.isEmpty( email ) )

      { //TODO: Add a default domain so mail address won't be required log.warn( "no email address is defined in developers list for '" + scmId + "' scm id." ); }

      else

      { // TODO: set a proper name InternetAddress to = new InternetAddress( email.trim() ); log.info( "Recipient: To '" + to + "'." ); message.addRecipient( Message.RecipientType.TO, to ); }

      }
      }

      <ciManagement>
      <system>continuum</system>
      <url>http://server/continuum/</url>
      <notifiers>
      <notifier>
      <type>mail</type>
      <sendOnError>true</sendOnError>
      <sendOnFailure>true</sendOnFailure>
      <sendOnSuccess>false</sendOnSuccess>
      <sendOnWarning>true</sendOnWarning>
      <configuration>
      <committers>true</committers>
      </configuration>
      </notifier>
      </notifiers>
      </ciManagement>

        Activity

        Hide
        Jose Morales Martinez added a comment -

        Fixex in 800837r for version 1.4.0.
        Fixed in 800811r for version 1.3.4.

        Show
        Jose Morales Martinez added a comment - Fixex in 800837r for version 1.4.0. Fixed in 800811r for version 1.3.4.

          People

          • Assignee:
            Jose Morales Martinez
            Reporter:
            Klaus Wienert
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: