Issue Details (XML | Word | Printable)

Key: CONTINUUM-2240
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Maria Catherine Tan
Reporter: Wendy Smoak
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Continuum

Passwords are exposed in request log

Created: 22/May/09 09:55 AM   Updated: 11/Aug/09 09:31 PM   Resolved: 11/Aug/09 09:31 PM
Return to search
Component/s: None
Affects Version/s: 1.3.3
Fix Version/s: 1.3.4

Time Tracking:
Not Specified

Environment: 1.3.3-SNAPSHOT r777534

Complexity: Intermediate


 Description  « Hide

Subversion passwords are exposed in plain text in the request log when adding a project, for example:

2009_05_22.request.log:0:0:0:0:0:0:0:1%0 - - [22/May/2009:14:45:32 +0000] "GET /continuum/addMavenTwoProject.action?scmUsername=wsmoak&_checkbox_scmUseCache=true&_checkbox_nonRecursiveProject=true&buildDefinitionTemplateId=1&m2PomUrl=http%3A%2F%2Fsvn.apache.org%2Frepos%2Fasf%2Fcontinuum%2Fsandbox%2Fsimple-example%2Fpom.xml&scmPassword=mypassw0rd&selectedProjectGroup=-1 HTTP/1.1" 302 0 "" "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10"

I assume this is a Jetty log file that we can't do anything about. If so, we need to document how to turn off this logging, or perhaps leave it off by default and document how to turn it on if needed.



Maria Catherine Tan added a comment - 24/Jul/09 06:40 AM

It also shows up in the browser's url field while refreshing the page when adding a project.


Maria Catherine Tan added a comment - 26/Jul/09 10:54 PM

setting the includeParams to false fixes this.

<META HTTP-EQUIV="refresh" CONTENT="2;url=<s:url includeParams="false"/>"/>

Does anyone have any objection with this change? If not i'll commit this


Maria Catherine Tan added a comment - 03/Aug/09 06:24 PM

Fixed in
r800620 of 1.3.x branch
r800622 of trunk


Maria Catherine Tan added a comment - 11/Aug/09 09:24 PM

Changes made in r800620 causes this warning:

WARN org.apache.struts2.components.URL - Unknown value for includeParams parameter to URL tag: false


Maria Catherine Tan added a comment - 11/Aug/09 09:31 PM

set includeParams to none

r803352 of 1.3.x branch
r803353 of trunk