Issue Details (XML | Word | Printable)

Key: CONTINUUM-2231
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Maria Catherine Tan
Reporter: Wendy Smoak
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Continuum

Queues page should include the prepare build queue

Created: 14/May/09 06:31 PM   Updated: 22/May/09 07:51 PM   Resolved: 22/May/09 07:50 PM
Return to search
Component/s: Parallel Builds
Affects Version/s: 1.3.2
Fix Version/s: 1.3.3

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. continuum-prepare-build-queue.png
(97 kB)
Issue Links:
Related

Complexity: Intermediate


 Description  « Hide

Currently when a forced or scheduled build kicks off, there is a delay before projects appear on the Queues page.

During this time according to the logs, they are in the 'prepare build' queue, but this is not visible through the web ui.

This causes users to think that nothing is happening.

The Queues page should also show what projects are in the 'prepare build' queue.



Wendy Smoak made changes - 14/May/09 06:32 PM
Field Original Value New Value
Link This issue relates to CONTINUUM-2229 [ CONTINUUM-2229 ]
Wendy Smoak made changes - 14/May/09 06:32 PM
Link This issue is related to CONTINUUM-2208 [ CONTINUUM-2208 ]
Maria Catherine Tan made changes - 18/May/09 06:48 PM
Fix Version/s 1.3.3 [ 15105 ]
Maria Catherine Tan made changes - 19/May/09 10:32 AM
Assignee Maria Catherine Tan [ ctan ]
Maria Catherine Tan added a comment - 19/May/09 08:39 PM

Fixed in
r776516 of 1.3.x branch
r776518 of trunk


Maria Catherine Tan made changes - 19/May/09 08:39 PM
Resolution Fixed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]
Wendy Smoak added a comment - 20/May/09 03:52 PM - edited

See screen shot, the message "Prepare Build Queue is empty" is displayed even when there is a project in the queue.

... it's a typo in this line:

> Modified: continuum/branches/continuum-1.3.x/continuum-webapp/src/main/webapp/WEB-INF/jsp/admin/buildQueueView.jsp
...
> + <c:if test="${empty prepaerBuildQueues}">


Wendy Smoak made changes - 20/May/09 03:52 PM
Attachment continuum-prepare-build-queue.png [ 42094 ]
Wendy Smoak added a comment - 20/May/09 04:13 PM

The order on the queues page is currently
prepare build
current build
checkout

I think the current build should be at the top. That's the most interesting/useful thing on the page, and when the page refreshes you can immediately see what's building.

That probably implies a reverse chronological order, so...

current build
checkout
prepare build

What do you think?


Wendy Smoak made changes - 20/May/09 04:14 PM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Wendy Smoak added a comment - 20/May/09 07:16 PM

or... is the 'checkout queue' only used when you first add a project, and not at all during scheduled/forced builds? In that case, maybe it should be:

current build
prepare build
current checkout

Also, this change needs a documentation update, so let's leave the issue open until that's done.

I didn't think Queues was documented at all, but grep turned up user_guides/viewing_queues/index.apt which isn't listed on the menu!


Maria Catherine Tan added a comment - 20/May/09 07:41 PM

Fixed in
r776901 of 1.3.x branch
r776902 of trunk

Thanks Wendy!


Maria Catherine Tan made changes - 20/May/09 08:33 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]
Wendy Smoak added a comment - 22/May/09 11:07 AM - edited

The project groups column should be links instead of plain text, like they are in the other sections on the page.

There should be a cancel icon next to the current item in the prepare build queue.

(These can be handled as separate issues if you want... I know you're trying to get 1.3.3 out. Let me know and I'll open them.)


Wendy Smoak made changes - 22/May/09 11:07 AM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Wendy Smoak made changes - 22/May/09 02:59 PM
Link This issue is related to CONTINUUM-2005 [ CONTINUUM-2005 ]
Maria Catherine Tan added a comment - 22/May/09 05:43 PM

The reason why I did not put a cancel icon next to the current item in prepare build queue is because it's doing an svn update, so I'd like to prevent having a corrupted working copy and will need the user to do an svn cleanup.

IIRC, previously we also don't allow cancellation while project is still updating?


Maria Catherine Tan added a comment - 22/May/09 06:29 PM

Yes, please open another issue if you still think we should have a cancel icon for current prepare build.


Wendy Smoak added a comment - 22/May/09 07:17 PM

No problem if there's a reason not to have a way to cancel it, but everything else on the page has one so we should mention in the docs why it's not there.

Do you mean there's a time when you can't cancel a current build? It looks like you can cancel a checkout, doesn't that suffer from the same problem? I'm looking at http://continuum.apache.org/docs/1.3.3-SNAPSHOT/administrator_guides/queues.html

It just needs the links then, and this one can be done.


Maria Catherine Tan added a comment - 22/May/09 07:35 PM

added link in project group column and also reorder queues when distributed build is enabled

777753 of 1.3.x branch
777754 of trunk


Maria Catherine Tan made changes - 22/May/09 07:35 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]
Maria Catherine Tan added a comment - 22/May/09 07:36 PM - edited

need to mention in the docs why we can't cancel current prepare build


Maria Catherine Tan made changes - 22/May/09 07:36 PM
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Fixed [ 1 ]
Maria Catherine Tan made changes - 22/May/09 07:50 PM
Resolution Fixed [ 1 ]
Status Reopened [ 4 ] Closed [ 6 ]