|
I think this is a step in the right direction. If the 'in queue' icon is displayed, then I expect to see the project listed on the 'Queues' page. (I also expect to be able to cancel it.) Those can be separate issues, I just wanted to raise the concern here as I don't think this is a complete fix for the "I clicked build but nothing is happening!" user perception problem. Projects won't be added to build queue until it finishes the prepare build successfully. So changing it to "in queue" icon might be confusing to users because they won't see the projects in the queues page. Instead of changing the icon of each project to "in queue" when they're in the the build prepare queue, we could change the icon of the project scm root url to "in queue" icon? WDYT? Also showing the prepare build queues in the Queues page will be a great help Has any work been done on this? On vmbuild (r777534) I'm seeing it show the 'checkout' icon next the scm url when the project is in the prepare build queue. http://people.apache.org/~wsmoak/continuum/continuum-scm-url-showing-checkout-instead-of-queued.png While it is currently prepare build, the icon next to the scm url will show a 'checkout' icon. But while it is still in the prepare build queue, no icon to indicate that it is already in queue. We can include in the documentation that when that "in queue" icon is displayed, it means that the project is either in the prepare build queue or in the build queue. Patch applied in Thanks Jan! Added documentation |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
attached patch. thanks