Continuum

Unable to notify latest committers only

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2.3, 1.3.1 (Alpha)
  • Fix Version/s: 1.3.2 (Beta)
  • Component/s: Notifier - Mail
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

When adding a mail notifier, the email address is required. This means you can't notify only the latest committers.

The email address field should be optional, at least not required when the 'latest committers' checkbox is enabled.

As discussed on the user list: http://markmail.org/message/oma2qfwn562bjns5

A workaround is to provide a non-existent email address in the form, and let it bounce or fail. Or, provide a valid email address and configure filters to delete the messages.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wendy Smoak added a comment -

I removed the required validation for the email address in r755050, however this isn't totally correct as it will now let you add a notifier with no email address even if the 'notify latest committers' box is not checked.

TODO: figure out conditional validation in s2, currently reading http://www.junlu.com/msg/394407.html

Show
Wendy Smoak added a comment - I removed the required validation for the email address in r755050, however this isn't totally correct as it will now let you add a notifier with no email address even if the 'notify latest committers' box is not checked. TODO: figure out conditional validation in s2, currently reading http://www.junlu.com/msg/394407.html
Hide
Permalink
Wendy Smoak added a comment -

Added conditional validation in r755063...

  • validation is working but error message is not displaying
  • using <field-validator> when according to docs it should be <validator>

docs: http://struts.apache.org/2.0.14/struts2-core/apidocs/com/opensymphony/xwork2/validator/Validator.html

We could move this into a 'validate' method, or use annotations.

Show
Wendy Smoak added a comment - Added conditional validation in r755063... validation is working but error message is not displaying using <field-validator> when according to docs it should be <validator> docs: http://struts.apache.org/2.0.14/struts2-core/apidocs/com/opensymphony/xwork2/validator/Validator.html We could move this into a 'validate' method, or use annotations.
Hide
Permalink
Wendy Smoak added a comment -

Fixed the validation message display in r755069 by adding <s:actionerror /> and <s:actionmessage> to notifierMail.jsp

Show
Wendy Smoak added a comment - Fixed the validation message display in r755069 by adding <s:actionerror /> and <s:actionmessage> to notifierMail.jsp

People

  • Assignee:
    Wendy Smoak
    Reporter:
    Wendy Smoak
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: