[#CONTINUUM-2107] Send on SCM Failure is duplicated on the Add/Edit Mail Notifier page - jira.codehaus.org

Continuum

Send on SCM Failure is duplicated on the Add/Edit Mail Notifier page

Created: 02/Mar/09 03:46 PM Updated: 06/Mar/09 10:41 AM Resolved: 06/Mar/09 10:41 AM

Component/s:

Notifier - Mail

Affects Version/s:

1.3.1 (Alpha)

Fix Version/s:

1.3.2 (Beta)

Time Tracking:

Not Specified

Issue Links:

Duplicate

This issue is duplicated by:

~~CONTINUUM-2113~~ Extra 'Send On SCM Failure' checkbox in notifiers page

Complexity:

Intermediate

Description

« Hide

The text 'Send on SCM Failure' appears twice on the Add/Edit mail notifier page.

Sort Order:

[ Permalink | « Hide ]

Jose Morales Martinez added a comment - 02/Mar/09 08:19 PM

This happens in all notifiers except Wagon Notifier.

In adittion, I think the label should be modified. Replace 'Send On SCM Failure' for 'Send on SCM Failure'. This way all labels follow the same pattern (lowercase).

[ Permalink | « Hide ]

Wendy Smoak added a comment - 06/Mar/09 09:57 AM

See patch on duplicate issue ~~CONTINUUM-2113~~

Is removing the second checkbox the right thing to do, or was it intended to be a checkbox for something else?

Removing it will fix this issue, but I wonder if something is missing.

[ Permalink | « Hide ]

Wendy Smoak added a comment - 06/Mar/09 10:41 AM

Applied patch from ~~CONTINUUM-2113~~ in r750968. Thanks, Nap!