Continuum
  1. Continuum
  2. CONTINUUM-2083

"Project name already exist" when creating a new ant or shell project in a recently created project group

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1 (Alpha)
    • Fix Version/s: 1.3.3 (Beta)
    • Component/s: Integration - Shell
    • Labels:
      None
    • Environment:
      Suse 9, Embedded Jetty servlet container, MySQL5
    • Complexity:
      Intermediate
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      When trying to add a new shell project, it always gives this error:
      "Project name already exist"
      This happens for the first time. After that, the project exists, but when we try to modify it, throws a NullPointerException.
      When executing the project, continuum ignores it. In the URL of the project execution request, we can see "projectGroupId=0", instead of the right group id, that in this case is "7".

      1. CONTINUUM-2083.patch
        7 kB
        Jose Morales Martinez

        Issue Links

          Activity

          Hide
          Jose Morales Martinez added a comment -

          I think they are two different bugs.

          The first, ("Project name already exist") is related with CONTINUUM-1952 and CONTINUUM-1859. This bug is because the validation occurs constantly, once created, is evaluated the validation and detect duplicated because it has been created.

          Respect the second bug, I'm still working on it. I can only replicate the second bug in version 1.3.x.

          I'm working to resolve this bugs.

          Show
          Jose Morales Martinez added a comment - I think they are two different bugs. The first, ("Project name already exist") is related with CONTINUUM-1952 and CONTINUUM-1859 . This bug is because the validation occurs constantly, once created, is evaluated the validation and detect duplicated because it has been created. Respect the second bug, I'm still working on it. I can only replicate the second bug in version 1.3.x. I'm working to resolve this bugs.
          Hide
          Wendy Smoak added a comment -

          Adding information formerly on CONTINUUM-1859:

          After adding a non-existent ant or shell project. Page doesn't redirect to the project group summary page. But page will display "Project name already exist". But user is added in the project group.

          ****************************************************
          Error in console of RESULT A:

          jvm 1 | 2008-08-28 12:11:53,987 [pool-6-thread-1] INFO action#checkout-project - Checking out project: 'antProject', id: '14' to '/home/gwen/Desktop/maestro-1.7.3/project-server/bin/linux-x86-32/target/working-directory/14' with branch/tag .
          jvm 1 | 2008-08-28 12:11:53,987 [pool-6-thread-1] ERROR action#checkout-project - No such provider: ''.
          jvm 1 | org.apache.maven.scm.manager.NoSuchScmProviderException: No such provider: ''.
          jvm 1 | at org.apache.maven.scm.manager.AbstractScmManager.getProviderByType(AbstractScmManager.java:171)
          jvm 1 | at org.apache.maven.scm.manager.AbstractScmManager.makeScmRepository(AbstractScmManager.java:199)
          jvm 1 | at org.apache.continuum.scm.DefaultContinuumScm.getScmRepository(DefaultContinuumScm.java:161)
          jvm 1 | at org.apache.continuum.scm.DefaultContinuumScm.checkout(DefaultContinuumScm.java:74)
          jvm 1 | at org.apache.maven.continuum.core.action.CheckoutProjectContinuumAction.execute(CheckoutProjectContinuumAction.java:119)
          jvm 1 | at org.apache.maven.continuum.scm.queue.CheckOutTaskExecutor.executeTask(CheckOutTaskExecutor.java:112)
          jvm 1 | at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116)
          jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442)
          jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176)
          jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665)
          jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690)
          jvm 1 | at java.lang.Thread.run(Thread.java:595)

          Show
          Wendy Smoak added a comment - Adding information formerly on CONTINUUM-1859 : After adding a non-existent ant or shell project. Page doesn't redirect to the project group summary page. But page will display "Project name already exist". But user is added in the project group. **************************************************** Error in console of RESULT A: jvm 1 | 2008-08-28 12:11:53,987 [pool-6-thread-1] INFO action#checkout-project - Checking out project: 'antProject', id: '14' to '/home/gwen/Desktop/maestro-1.7.3/project-server/bin/linux-x86-32/target/working-directory/14' with branch/tag . jvm 1 | 2008-08-28 12:11:53,987 [pool-6-thread-1] ERROR action#checkout-project - No such provider: ''. jvm 1 | org.apache.maven.scm.manager.NoSuchScmProviderException: No such provider: ''. jvm 1 | at org.apache.maven.scm.manager.AbstractScmManager.getProviderByType(AbstractScmManager.java:171) jvm 1 | at org.apache.maven.scm.manager.AbstractScmManager.makeScmRepository(AbstractScmManager.java:199) jvm 1 | at org.apache.continuum.scm.DefaultContinuumScm.getScmRepository(DefaultContinuumScm.java:161) jvm 1 | at org.apache.continuum.scm.DefaultContinuumScm.checkout(DefaultContinuumScm.java:74) jvm 1 | at org.apache.maven.continuum.core.action.CheckoutProjectContinuumAction.execute(CheckoutProjectContinuumAction.java:119) jvm 1 | at org.apache.maven.continuum.scm.queue.CheckOutTaskExecutor.executeTask(CheckOutTaskExecutor.java:112) jvm 1 | at org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable$1.run(ThreadedTaskQueueExecutor.java:116) jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:442) jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.FutureTask.run(FutureTask.java:176) jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:665) jvm 1 | at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:690) jvm 1 | at java.lang.Thread.run(Thread.java:595)
          Hide
          Jose Morales Martinez added a comment -

          This patch fixes the bug. I have moved the alreadyExist validation form validate method to add method. After many attempts this is the most elegant solution I've found.

          Show
          Jose Morales Martinez added a comment - This patch fixes the bug. I have moved the alreadyExist validation form validate method to add method. After many attempts this is the most elegant solution I've found.
          Hide
          Maria Catherine Tan added a comment -

          Questions:

          1. Can I add Project Name: Ant with Version: 1.0 and Project Name: Ant with Version: 2.0 to the same project group?

          2. Can we add a Project with the same name and version but to a different project group?

          Show
          Maria Catherine Tan added a comment - Questions: 1. Can I add Project Name: Ant with Version: 1.0 and Project Name: Ant with Version: 2.0 to the same project group? 2. Can we add a Project with the same name and version but to a different project group?
          Hide
          Jose Morales Martinez added a comment -

          In CONTINUUM-1445 indicated that the validation is done by projectname, version and scmurl. Currently, The validation is for all projects.

          I think we have to decide is a global validation (all projects) or only for the target project group .

          Show
          Jose Morales Martinez added a comment - In CONTINUUM-1445 indicated that the validation is done by projectname, version and scmurl. Currently, The validation is for all projects. I think we have to decide is a global validation (all projects) or only for the target project group .
          Hide
          Wendy Smoak added a comment -

          Has a decision been made here? I can be convinced either way, as long as it's documented.

          Show
          Wendy Smoak added a comment - Has a decision been made here? I can be convinced either way, as long as it's documented.
          Hide
          Jose Morales Martinez added a comment -

          I can not make the final decision. The patch now checks all projects.I think we should consider the question: Is it neccesary to have a duplicate project? I think not, but if we want to make more flexible, we could check project group.

          Show
          Jose Morales Martinez added a comment - I can not make the final decision. The patch now checks all projects.I think we should consider the question: Is it neccesary to have a duplicate project? I think not, but if we want to make more flexible, we could check project group.
          Hide
          Emmanuel Venisse added a comment -

          Patch already applied.

          Show
          Emmanuel Venisse added a comment - Patch already applied.

            People

            • Assignee:
              Jose Morales Martinez
              Reporter:
              Manuel Guerrero
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: