Continuum

Add confirmation upon deletion in Parallel Build Queue

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.3.1 (Alpha)
  • Fix Version/s: 1.3.2 (Beta)
  • Component/s: Parallel Builds
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    1

Description

Parallel Build Queue must have confirmation upon deletion

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
jan ancajas added a comment -

attach patch for review. thanks

Show
jan ancajas added a comment - attach patch for review. thanks
Hide
Permalink
Wendy Smoak added a comment -

Applied with modifications in r751144, thanks for the patch!

I renamed confirmDeleteParallelBuilds.jsp to confirmDeleteBuildQueue.jsp, and changed the localization properties to deleteBuildQueue.*. There was also an unused import since BuildQueueAction now extends a different class.

This new page flow is a candidate for a Selenium test, if anyone's interested...

Show
Wendy Smoak added a comment - Applied with modifications in r751144, thanks for the patch! I renamed confirmDeleteParallelBuilds.jsp to confirmDeleteBuildQueue.jsp, and changed the localization properties to deleteBuildQueue.*. There was also an unused import since BuildQueueAction now extends a different class. This new page flow is a candidate for a Selenium test, if anyone's interested...

People

  • Assignee:
    Wendy Smoak
    Reporter:
    jan ancajas
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: