[#CONTINUUM-2028] Continuum release prepare should use maven-release-plugin scmCommentPrefix configuration in pom - jira.codehaus.org

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 1.2.2
Fix Version/s: 1.3.2 (Beta)
Component/s: None
Labels:
None
Environment:
Continuum 1.2.2, Subversion

Complexity:
Intermediate
Number of attachments :
0

Description

I have a Subversion repository with a pre-commit hook that requires a valid issue tracker id in every commit message.

The default commit message for release prepare is "[maven-release-manager] prepare for next development iteration" which is not acceptable.

I tried configuring the scmCommentPrefix for the release plugin in the pom, but the commit message still came out as [maven-release-manager] and was rejected.

  <build>
    <plugins>
      <plugin>
        <artifactId>maven-release-plugin</artifactId>
        <configuration>
          <scmCommentPrefix>[ABCD1234]</scmCommentPrefix>
        </configuration>
      </plugin>
    </plugins>
  </build>

Issue Links

This issue relates to:
CONTINUUM-2054	Ability to configure the scm comment prefix through the web UI for release prepare

This issue is related to:
CONTINUUM-1503	scm release tag default should match what the release plugin uses
CONTINUUM-1505	release perform page does not use defaults specified in pom for release plugin for goals and useReleaseProfile
CONTINUUM-1504	when autoVersionSubmodules=true is defined in the pom for the release plugin, the release prepare screen should not show or allow changing of child project versions
CONTINUUM-1633	release using mvn release plugin

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Wendy Smoak added a comment - 30/Dec/08 5:16 PM

While I'd love to see this fixed, I don't want to load up 1.3.1 with more than absolutely necessary.

This seems to be a larger problem than this one config element – see CONTINUUM1633, ~~CONTINUUM-1503~~, ~~CONTINUUM-1504~~, ~~CONTINUUM-1505~~ which all point to different release plugin config being ignored.

Show

Wendy Smoak added a comment - 30/Dec/08 5:16 PM While I'd love to see this fixed, I don't want to load up 1.3.1 with more than absolutely necessary. This seems to be a larger problem than this one config element – see CONTINUUM1633, ~~CONTINUUM-1503~~, ~~CONTINUUM-1504~~, ~~CONTINUUM-1505~~ which all point to different release plugin config being ignored.

Hide

Permalink

Olivier Lamy added a comment - 30/Dec/08 5:22 PM - edited

Ok.
We can try to fix that for 1.2.3
Will you have time to test this ? (because testing the release through UI need times).

Show

Olivier Lamy added a comment - 30/Dec/08 5:22 PM - edited Ok. We can try to fix that for 1.2.3 Will you have time to test this ? (because testing the release through UI need times).

Hide

Permalink

Wendy Smoak added a comment - 30/Dec/08 5:27 PM

Yes I have time to test it. If you've got a fix in mind already, go for it – on trunk!

I simply meant I didn't want this to block a 1.3.1 release once we have the database upgrade issue sorted out. (Fix for 1.3.x instead of 1.3.1, that's all.)

Show

Wendy Smoak added a comment - 30/Dec/08 5:27 PM Yes I have time to test it. If you've got a fix in mind already, go for it – on trunk! I simply meant I didn't want this to block a 1.3.1 release once we have the database upgrade issue sorted out. (Fix for 1.3.x instead of 1.3.1, that's all.)

Hide

Permalink

Julien HENRY added a comment - 30/Jan/09 8:51 AM

It would be great to be able to give the scm comment prefix in the Continuum UI when doing the release. I also have a pre-commit hook in my organisation but the issue tracker is different for each release so it is not a good solution for me to store it in the pom.

Show

Julien HENRY added a comment - 30/Jan/09 8:51 AM It would be great to be able to give the scm comment prefix in the Continuum UI when doing the release. I also have a pre-commit hook in my organisation but the issue tracker is different for each release so it is not a good solution for me to store it in the pom.

Hide

Permalink

Wendy Smoak added a comment - 30/Jan/09 9:02 AM

I opened ~~CONTINUUM-2054~~ for the further enhancement of configuring this through the Web UI.

Even if the issue key changes for every release, you can still configure it in the pom prior to executing the release process.

Show

Wendy Smoak added a comment - 30/Jan/09 9:02 AM I opened ~~CONTINUUM-2054~~ for the further enhancement of configuring this through the Web UI. Even if the issue key changes for every release, you can still configure it in the pom prior to executing the release process.

Hide

Permalink

Julien HENRY added a comment - 30/Jan/09 9:21 AM

Thanks for opening the enhancement request.

The main advantage of releasing through Continuum Web UI is it is not needed to checkout the code source (can be done from a non developer computer). If I have to edit the pom before releasing, I have to checkout/commit so it reduces Continuum usefulness.

Show

Julien HENRY added a comment - 30/Jan/09 9:21 AM Thanks for opening the enhancement request. The main advantage of releasing through Continuum Web UI is it is not needed to checkout the code source (can be done from a non developer computer). If I have to edit the pom before releasing, I have to checkout/commit so it reduces Continuum usefulness.

Hide

Permalink

Emmanuel Venisse added a comment - 04/Feb/09 3:55 PM

Done in r.740906

Show

Emmanuel Venisse added a comment - 04/Feb/09 3:55 PM Done in r.740906

Hide

Permalink

Wendy Smoak added a comment - 06/Feb/09 9:42 AM

This doesn't seem to be working in r740908

with this in the pom:

<plugin>
<artifactId>maven-release-plugin</artifactId>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
<scmCommentPrefix>[HELLO-455] </scmCommentPrefix>
</configuration>
</plugin>

the commit message was:

Author: wsmoak
Date: 2009-02-06 09:35:17 -0600 (Fri, 06 Feb 2009)
New Revision: 1182

Modified:
hello/trunk/pom.xml
Log:
[maven-release-manager] prepare release hello-1.1.6

I also noticed the SCM Comment Prefix on the release prepare page didn't pre-populate with the value in the pom, so it may be related to ~~CONTINUUM-2054~~.

I'll modify one of the examples in the sandbox and record a Selenium test to double check.

Show

Wendy Smoak added a comment - 06/Feb/09 9:42 AM This doesn't seem to be working in r740908 with this in the pom: <plugin> <artifactId>maven-release-plugin</artifactId> <configuration> <autoVersionSubmodules>true</autoVersionSubmodules> <scmCommentPrefix>[HELLO-455] </scmCommentPrefix> </configuration> </plugin> the commit message was: Author: wsmoak Date: 2009-02-06 09:35:17 -0600 (Fri, 06 Feb 2009) New Revision: 1182 Modified: hello/trunk/pom.xml Log: [maven-release-manager] prepare release hello-1.1.6 I also noticed the SCM Comment Prefix on the release prepare page didn't pre-populate with the value in the pom, so it may be related to ~~CONTINUUM-2054~~. I'll modify one of the examples in the sandbox and record a Selenium test to double check.

Hide

Permalink

Emmanuel Venisse added a comment - 07/Feb/09 4:04 AM

It works fine.

Show

Emmanuel Venisse added a comment - 07/Feb/09 4:04 AM It works fine.

Hide

Permalink

Wendy Smoak added a comment - 08/Feb/09 9:06 AM

It works fine for me at r741756. Thanks for taking a look, Emmanuel. Maybe you fixed it by adding the missing 'get' method?

Show

Wendy Smoak added a comment - 08/Feb/09 9:06 AM It works fine for me at r741756. Thanks for taking a look, Emmanuel. Maybe you fixed it by adding the missing 'get' method?

Hide

Permalink

Emmanuel Venisse added a comment - 08/Feb/09 4:08 PM

Yes probably.

Show

Emmanuel Venisse added a comment - 08/Feb/09 4:08 PM Yes probably.

People

Assignee:

Emmanuel Venisse

Reporter:

Wendy Smoak

Vote (2)

Watch (2)

Dates

Created:

30/Dec/08 4:54 PM

Updated:

08/Feb/09 4:08 PM

Resolved:

04/Feb/09 3:55 PM