Issue Details (XML | Word | Printable)

Key: CONTINUUM-1981
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Olivier Lamy
Reporter: George Gastaldi
Votes: 1
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Continuum

Error while using Windows domain in username when adding a M2 project

Created: 18/Nov/08 08:18 AM   Updated: 06/Dec/08 11:37 AM   Resolved: 06/Dec/08 11:37 AM
Return to search
Component/s: SCM
Affects Version/s: 1.2.2
Fix Version/s: 1.2.3, 1.3.1

Time Tracking:
Not Specified

File Attachments: 1. Text File continuum-1981.patch (2 kB)

Environment: Apache/2.0.58 (Win32) DAV/2 SVN/1.4.3 mod_auth_sspi/1.0.3 Server at myserver Port 8080

Complexity: Intermediate


 Description  « Hide

I am trying to add a maven 2.0.x project but have not figured out how to specify a username that must contain the windows domain.

Add Maven 2.0+ Project
POM Url: http://myserver:81/svn/my_code/my_project/trunk/pom.xml
Username: mydomain\myusername
Password: x

The message I see in the web browser is:

The specified resource cannot be accessed. Please try again later or contact your administrator.

If I go directly to the URL in IE/Firefox I am prompted for my username/password. I enter my username with windows domain (mydomain\myusername) in the prompt and am able to view the pom file. Is there a special format for specifying a windows domain with the username on the Add Maven 2.0+ Project page?

The log gives me this (it IS a valid pom.xml):

2008-11-18 10:53:55,805 [addMavenTwoProjectBackgroundThread] INFO  action#create-projects-from-metadata  - checking for settings auth setup
2008-11-18 10:53:55,821 [addMavenTwoProjectBackgroundThread] INFO  continuumProjectBuilder#maven-two-builder  - Downloading http://w034-0:*****@myserver:81/svn/my_code/my_project/trunk/pom.xml
2008-11-18 10:53:55,868 [addMavenTwoProjectBackgroundThread] WARN  continuumProjectBuilder#maven-two-builder  - skip non handled http return code 403
2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] ERROR mavenBuilderHelper  - Cannot build maven project from C:\apache-continuum-1.2.2\tmp\continuum\svn\my_code\my_project\trunk\pom.xml (Not a v4.0.0 POM. for project unknown at C:\apache-continuum-1.2.2\tmp\continuum\svn\my_code\my_project\trunk\pom.xml).

2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] INFO  continuum  - Created 0 projects.
2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] INFO  continuum  - Created 0 project groups.
2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] INFO  continuum  - 1 errors.
2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] INFO  continuum  - 1 errors during project add: 
2008-11-18 10:53:55,883 [addMavenTwoProjectBackgroundThread] INFO  continuum  - Not a v4.0.0 POM. for project unknown at C:\apache-continuum-1.2.2\tmp\continuum\continuum\svn\my_code\my_project\trunk\pom.xml

Check this link for more details.



George Gastaldi added a comment - 18/Nov/08 08:24 AM

In the log, it shows my try without the domain\
w034-0 is my real username on the logs.


George Gastaldi added a comment - 18/Nov/08 08:38 AM

Workaround: Using %5C as the backslash works.
The code should be changed to call java.net.URLEncoder.encode(string,"ISO-8859-1");


George Gastaldi added a comment - 18/Nov/08 08:39 AM

Wendy comments on IRC:

<wsmoak> I'm curious whether that will work later – now it's stored that in the database and will pass it with svn update --username
<wsmoak> you might need to edit the project and change it back


George Gastaldi added a comment - 18/Nov/08 10:26 AM

Wendy,

I just tested that. When used %5C as the backslash, the user is stored in database as "\", so that is not a problem.

Regards,

George


George Gastaldi added a comment - 18/Nov/08 11:33 AM

Patch Attached !

Class org.apache.maven.continuum.web.action.AddMavenProjectAction in project continuum-webapp changed


Olivier Lamy added a comment - 02/Dec/08 03:24 PM

Are you using a tool like visualsvn and configuring windows Authentication instead of svn auth ?


George Gastaldi added a comment - 02/Dec/08 03:40 PM

I have TortoiseSVN installed on my machine, but I didnt configured a thing about it.


Olivier Lamy added a comment - 06/Dec/08 11:37 AM

Fixed in rev 724016 (1.2.x branch)
Merge in trunk rev 724017
Patch apply with minor change : use encoding value from httpServletRequest.getCharacterEncoding() if null use system encoding.
Thanks.