Continuum
  1. Continuum
  2. CONTINUUM-1953

[regression] Build definitions not linked when creating a new project with a given build defintion template

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2
    • Fix Version/s: 1.2.3
    • Component/s: Web - Configuration
    • Labels:
      None
    • Environment:
      Linux / Java 1.6.0_10 / mvn 2.0.9
    • Complexity:
      Intermediate
    • Number of attachments :
      0

      Description

      When adding a new Maven2 project with the Web interface, I'm associating the project with a given BuildDefinitionTemplate.
      The project is created but no build definition is associated to the project. I need to associate all the build definitions of the template manually to the project.

      It looks like the function AddMavenProjectAction.setBuildDefinitionTemplateId() is never called.

      I have migrated from Continuum 1.1 to 1.2 . It used to work in previous version.

        Issue Links

          Activity

          Hide
          Wendy Smoak added a comment -

          If it's not a regression and you don't see a quick fix for 1.2.3, then bumping it to a 1.3.x is fine with me.

          (I'd prefer to get 1.2.3 out with the things that are already fixed, and I'm not committed to doing a 1.2.4 at this time.)

          Show
          Wendy Smoak added a comment - If it's not a regression and you don't see a quick fix for 1.2.3, then bumping it to a 1.3.x is fine with me. (I'd prefer to get 1.2.3 out with the things that are already fixed, and I'm not committed to doing a 1.2.4 at this time.)
          Hide
          Olivier Lamy added a comment -

          fix rev 726239 in branch 1.2.x
          merge in trunk rev 726243.

          Show
          Olivier Lamy added a comment - fix rev 726239 in branch 1.2.x merge in trunk rev 726243.
          Hide
          Wendy Smoak added a comment -

          Now when I test this, I do get the build defs from the template, but I also get the default build definition.

          That shouldn't happen. If I choose a particular template when adding a project, only the build defs associated with that template should be added.

          I added another line to the Selenium IDE test to clarify this, and left it in the failing category.

          Do you want to reopen this or handle it as a separate issue?

          Show
          Wendy Smoak added a comment - Now when I test this, I do get the build defs from the template, but I also get the default build definition. That shouldn't happen. If I choose a particular template when adding a project, only the build defs associated with that template should be added. I added another line to the Selenium IDE test to clarify this, and left it in the failing category. Do you want to reopen this or handle it as a separate issue?
          Hide
          Olivier Lamy added a comment -

          Does it happened when you add the project to an existing project group (an empty project group) ?
          I should say it's normal because when you create an empty project group the default m2 buiid def is associated to this new project group.
          I have created a unit test in core (src/test/java/org/apache/maven/continuum/AddMaven2ProjectTest.java) which check four cases :

          • adding a project with a template to an existing projectGroup
          • adding a project without a template to an existing projectGroup
          • adding a project with a template with auto projectGroup creation
          • adding a project without a template with auto projectGroup creation

          comment added in the unit rev 726462.

          IMHO We should add a new feature : creating project group with a build template

          Show
          Olivier Lamy added a comment - Does it happened when you add the project to an existing project group (an empty project group) ? I should say it's normal because when you create an empty project group the default m2 buiid def is associated to this new project group. I have created a unit test in core (src/test/java/org/apache/maven/continuum/AddMaven2ProjectTest.java) which check four cases : adding a project with a template to an existing projectGroup adding a project without a template to an existing projectGroup adding a project with a template with auto projectGroup creation adding a project without a template with auto projectGroup creation comment added in the unit rev 726462. IMHO We should add a new feature : creating project group with a build template
          Hide
          Wendy Smoak added a comment -

          You're right, it was an existing project group, and it picked up the default build def from the group plus the ones from the template I selected.

          Show
          Wendy Smoak added a comment - You're right, it was an existing project group, and it picked up the default build def from the group plus the ones from the template I selected.

            People

            • Assignee:
              Olivier Lamy
              Reporter:
              Jean-Paul GUIGUI
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: