Continuum

Project Information tab's Add/Edit Notifiers links contain leading whitespace

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Component/s: None
  • Labels:
    None
  • Complexity:
    Intermediate
  • Number of attachments :
    0

Description

The Add and Edit Notifier links on the Project Information tab contain leading whitespace.

This confuses some proxies which need to re-write the urls, which causes errors when the links are clicked.

On the Notifiers tab, the html for the Delete link looks like this:

        <a href="/continuum/deleteProjectGroupNotifier!default.action?confirmed=false&amp;notifierType=mail&amp;projectGroupId=7&amp;notifierId=1">

          <img src="/continuum/images/delete.gif" alt="Delete" title="Delete" border="0">
        </a>

But on the Project Information Tab, Notifiers section, the delete link is:

                      <a href="%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20/continuum/deleteProjectNotifier%21default.action?projectId=8&amp;notifierType=mail&amp;projectGroupId=7&amp;notifierId=2">
                        <img src="/continuum/images/delete.gif" alt="Delete" title="Delete" border="0"></a>

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Wendy Smoak added a comment -

Patch for continuum/webapp/WEB-INF/jsp/projectView.jsp, based on the 'delete' link on .../jsp/components/projectGroupNotifierSummaryComponent.jsp . The 'edit' link also needs to be fixed.

$ diff -u projectView.jsp.orig projectView.jsp
--- projectView.jsp.orig        2008-06-11 15:23:00.000000000 -0700
+++ projectView.jsp     2008-06-11 15:39:57.000000000 -0700
@@ -132,13 +132,15 @@
                 <redback:ifAuthorized permission="continuum-modify-group" resource="${project.projectGroup.name}">
                   <c:choose>
                     <c:when test="${!pageScope.notifier.fromProject}">
-                      <a href='<ww:url value="/deleteProjectNotifier!default.action">
+                      <ww:url id="removeUrl" action="deleteProjectNotifier" namespace="/">
                         <ww:param name="projectId" value="project.id"/>
                         <ww:param name="projectGroupId" value="${project.projectGroup.id}"/>
                         <ww:param name="notifierType">${notifier.type}</ww:param>
                         <ww:param name="notifierId" value="${notifier.id}"/>
-                        </ww:url>'>
-                        <img src="<ww:url value='/images/delete.gif' includeParams="none"/>" alt="<ww:text name='delete'/>" title="<ww:text name='delete'/>" border="0"></a>
+                    </ww:url>
+                    <ww:a href="%{removeUrl}">
+                      <img src="<ww:url value='/images/delete.gif' includeParams="none"/>" alt="<ww:text name="delete"/>" title="<ww:text name="delete"/>" border="0">
+                    </ww:a>
                     </c:when>
                     <c:otherwise>
                       <img src="<ww:url value='/images/delete_disabled.gif' includeParams="none"/>" alt="<ww:text name='edit'/>" title="<ww:text name='edit'/>" border="0" />
Show
Wendy Smoak added a comment - Patch for continuum/webapp/WEB-INF/jsp/projectView.jsp, based on the 'delete' link on .../jsp/components/projectGroupNotifierSummaryComponent.jsp . The 'edit' link also needs to be fixed. $ diff -u projectView.jsp.orig projectView.jsp --- projectView.jsp.orig 2008-06-11 15:23:00.000000000 -0700 +++ projectView.jsp 2008-06-11 15:39:57.000000000 -0700 @@ -132,13 +132,15 @@ <redback:ifAuthorized permission="continuum-modify-group" resource="${project.projectGroup.name}"> <c:choose> <c:when test="${!pageScope.notifier.fromProject}"> - <a href='<ww:url value="/deleteProjectNotifier!default.action"> + <ww:url id="removeUrl" action="deleteProjectNotifier" namespace="/"> <ww:param name="projectId" value="project.id"/> <ww:param name="projectGroupId" value="${project.projectGroup.id}"/> <ww:param name="notifierType">${notifier.type}</ww:param> <ww:param name="notifierId" value="${notifier.id}"/> - </ww:url>'> - <img src="<ww:url value='/images/delete.gif' includeParams="none"/>" alt="<ww:text name='delete'/>" title="<ww:text name='delete'/>" border="0"></a> + </ww:url> + <ww:a href="%{removeUrl}"> + <img src="<ww:url value='/images/delete.gif' includeParams="none"/>" alt="<ww:text name="delete"/>" title="<ww:text name="delete"/>" border="0"> + </ww:a> </c:when> <c:otherwise> <img src="<ww:url value='/images/delete_disabled.gif' includeParams="none"/>" alt="<ww:text name='edit'/>" title="<ww:text name='edit'/>" border="0" />
Hide
Permalink
Wendy Smoak added a comment -

Fixed in r667242. Links are now as follows:

                      <a href="/editProjectNotifier.action?projectId=1&amp;notifierType=mail&amp;projectGroupId=1&amp;notifierId=1">
                        <img src="/images/edit.gif" alt="Edit" title="Edit" border="0">
                      </a>

                    <a href="/deleteProjectNotifier.action?projectId=1&amp;notifierType=mail&amp;projectGroupId=1&amp;notifierId=1">
                      <img src="/images/delete.gif" alt="Delete" title="Delete" border="0">
                    </a>
Show
Wendy Smoak added a comment - Fixed in r667242. Links are now as follows: <a href="/editProjectNotifier.action?projectId=1&amp;notifierType=mail&amp;projectGroupId=1&amp;notifierId=1"> <img src="/images/edit.gif" alt="Edit" title="Edit" border="0"> </a> <a href="/deleteProjectNotifier.action?projectId=1&amp;notifierType=mail&amp;projectGroupId=1&amp;notifierId=1"> <img src="/images/delete.gif" alt="Delete" title="Delete" border="0"> </a>

People

  • Assignee:
    Wendy Smoak
    Reporter:
    Wendy Smoak
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: