Continuum

Duplicate Profile names are accepted

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1
  • Fix Version/s: 1.2
  • Component/s: Core - Profiles
  • Labels:
    None
  • Environment:
    WinXP
  • Complexity:
    Intermediate
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

When adding or editing Profiles, names can be duplicated.

Activity

Hide
Olivier Lamy added a comment -

This must be check in updateProfile too.
I won't use the patch because IMHO this must be managed in core and not in the UI part.
I will add an Exception called AlreadyExistsProfileException which will be throw by updateProfile and addProfile

Show
Olivier Lamy added a comment - This must be check in updateProfile too. I won't use the patch because IMHO this must be managed in core and not in the UI part. I will add an Exception called AlreadyExistsProfileException which will be throw by updateProfile and addProfile
Hide
Olivier Lamy added a comment -

fixed in rev 654966

Show
Olivier Lamy added a comment - fixed in rev 654966
Hide
Wendy Smoak added a comment - - edited

When I edit an existing profile and save my changes, I get:

Action Error

  • A Profile with the same name already exists

(It does go ahead and save the changes though.)

I'm assuming this change introduced that behavior; I didn't go back and test it prior to this commit.

Show
Wendy Smoak added a comment - - edited When I edit an existing profile and save my changes, I get: Action Error
  • A Profile with the same name already exists
(It does go ahead and save the changes though.) I'm assuming this change introduced that behavior; I didn't go back and test it prior to this commit.
Hide
Olivier Lamy added a comment -

fixed in rev 655192.
Thanks Wendy for catching it.
And thanks again for the coming review

Show
Olivier Lamy added a comment - fixed in rev 655192. Thanks Wendy for catching it. And thanks again for the coming review

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: