Continuum

Adding Number of Errors and Test Success Rate to Notification Email

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2
  • Fix Version/s: 1.2.1
  • Component/s: Notifier - Mail
  • Labels:
    None
  • Environment:
    Windows Vista
  • Complexity:
    Intermediate
  • Testcase included:
    yes
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

To have the number of tests in error and the success rate of tests in the notification mail sent after every build.

Why is it required - Because, currently the mail gives a wrong sense of success rate in tests where as there may be a good number of tests in error. Even though, ppl can go and check the online report, having the summary in the mails is important.

Was there any reason behind excluding test errors? - Not Sure

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Murali Mohan added a comment -

The patch for this request is attached. Please review this and commit, if good. A Junit test also has been changed to test the changes. The changes are minor

Show
Murali Mohan added a comment - The patch for this request is attached. Please review this and commit, if good. A Junit test also has been changed to test the changes. The changes are minor
Hide
Permalink
Joel Turkel added a comment - - edited

With your fix it looks like the failure details aren't being reported properly for test errors. I believe the fix is to swap lines 185 and 186 in continuum-reports\src\main\java\org\apache\maven\continuum\reports\surefire\ReportTestSuite.java. Also the velocity template should probably be updated to include test failures/errors section if there are test failures or test errors.

Show
Joel Turkel added a comment - - edited With your fix it looks like the failure details aren't being reported properly for test errors. I believe the fix is to swap lines 185 and 186 in continuum-reports\src\main\java\org\apache\maven\continuum\reports\surefire\ReportTestSuite.java. Also the velocity template should probably be updated to include test failures/errors section if there are test failures or test errors.
Hide
Permalink
Emmanuel Venisse added a comment -

Ptch applied in r.703056. Thanks.

Show
Emmanuel Venisse added a comment - Ptch applied in r.703056. Thanks.

People

  • Assignee:
    Emmanuel Venisse
    Reporter:
    Murali Mohan
Vote (3)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: