Continuum
  1. Continuum
  2. CONTINUUM-1689

Bad string replacement of entities in build result

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1, 1.3.4 (Beta)
    • Fix Version/s: 1.4.1
    • Component/s: Web - UI
    • Labels:
      None
    • Complexity:
      Intermediate
    • Number of attachments :
      1

      Description

      I just noticed that the output of maven is wrongly encoded. Here's one of lines of he generated html source :
      [INFO] Setting property: resource.loader => 'classpath'.

      Remind: In the console, the output is the following (output of mvn site) :
      [INFO] Setting property: resource.loader => 'classpath'.

      As you can see, there's a problem
      I guess the entity conversion is done twice :

      • first "=>" is converted "=>"

      then another pass detects the & although it shouldn't process it anymore, so :

      • second "=>" is in turn converted "=>"

      I guess the correction weight might depend on how those conversion are done. As a lot of conversions produces an &, maybe encoding & as & should be the very first conversion to be done in the list ?
      Maybe even some "dependency" tree could do the trick (or even better, an API that already does that neatly ).

      Cheers.

      Let me know if you need anything else.

        Activity

        Hide
        Wendy Smoak added a comment -

        Confirmed in 1.3.4 by adding -X to the arguments of a simple project.

        For example, instead of

        OS name: "mac os x" version: "10.5.8" arch: "x86_64" Family: "mac"
        

        the output has

        OS name: "mac os x" version: "10.5.8" arch: "x86_64" Family: "mac"
        

        and

        Instead of

        [DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-clean-plugin:2.2:clean' -->
        

        the output has

        [DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-clean-plugin:2.2:clean' -->
        
        Show
        Wendy Smoak added a comment - Confirmed in 1.3.4 by adding -X to the arguments of a simple project. For example, instead of OS name: "mac os x" version: "10.5.8" arch: "x86_64" Family: "mac" the output has OS name: "mac os x" version: "10.5.8" arch: "x86_64" Family: "mac" and Instead of [DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-clean-plugin:2.2:clean' --> the output has [DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-clean-plugin:2.2:clean' -->
        Hide
        Chris Lim added a comment -

        Here's a patch that resolves html encoding issue.

        Show
        Chris Lim added a comment - Here's a patch that resolves html encoding issue.
        Hide
        Maria Odea Ching added a comment -

        Patch fixes the problem. I applied it to trunk in -r1132877. Thanks Chris!

        Show
        Maria Odea Ching added a comment - Patch fixes the problem. I applied it to trunk in -r1132877 . Thanks Chris!

          People

          • Assignee:
            Maria Odea Ching
            Reporter:
            Baptiste MATHUS
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: